feat: add java memory arguments #8115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
mo-auto
added
comp-charts-jans
kind-feature
iromli
requested changes
Mar 21, 2024
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
moabu
requested changes
Mar 22, 2024
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
iromli
requested changes
Mar 23, 2024
| {{ $memory := .Values.resources.limits.memory | replace "Mi" "" | int -}} | ||
| {{- $maxDirectMemory := printf "-XX:MaxDirectMemorySize=%dm" $memory -}} | ||
| {{- $xmx := printf "-Xmx%dm" (sub $memory 300) -}} | ||
| {{- $customJavaOptions := printf "%s %s " $custom (printf "%s %s" $maxDirectMemory $xmx) -}} |
There was a problem hiding this comment.
This line can be simplified into:
{{- $customJavaOptions := printf "%s %s %s" $custom $maxDirectMemory $xmx -}}
| {{- $maxDirectMemory := printf "-XX:MaxDirectMemorySize=%dm" $memory -}} | ||
| {{- $xmx := printf "-Xmx%dm" (sub $memory 300) -}} | ||
| {{- $customJavaOptions := printf "%s %s " $custom (printf "%s %s" $maxDirectMemory $xmx) -}} | ||
| {{ $customJavaOptions | trimSuffix " " | quote }} |
There was a problem hiding this comment.
If cnCustomJavaOptions is set to empty string, the generated YAML would be:
- name: CN_AUTH_JAVA_OPTIONS
value: " -XX:MaxDirectMemorySize=2500m -Xmx2200m"
Notice the leading whitespace.
It's better to use trim instead of trimSuffix to remove leading and trailing whitespaces.
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
iromli
approved these changes
Mar 26, 2024
moabu
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8114