Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-casa): reimplement bioid plugin #8180

Merged
merged 10 commits into from
Apr 4, 2024
Merged

feat(jans-casa): reimplement bioid plugin #8180

merged 10 commits into from
Apr 4, 2024

Conversation

SafinWasi
Copy link
Contributor

Prepare

Description

Target issue

closes #8169

Implementation Details

Reimplements the BioID casa plugin to use an Agama flow for enrollment.

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@SafinWasi
fix(jans-casa): fix imports
32bcc7d 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi
refactor(jans-casa): new style
6291cc8 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi
refactor(jans-casa): change UI
98a7fd5 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi
refactor: add agama
c8c9db0 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi
feat(jans-casa): bioid code storage
65e3810 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi
chore: delete dummy files
8111723 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi
feat(jans-casa): add full bioid flow
8f8565d 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi
feat(jans-casa): fix labels
f3a55d3 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi
docs(jans-casa): add bioid document
943a872 
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-agama Touching folder /agama kind-feature Issue or PR is a new feature request labels Mar 29, 2024
@SafinWasi SafinWasi marked this pull request as ready for review April 1, 2024 14:37
@nynymike nynymike self-requested a review April 3, 2024 22:28
nynymike
nynymike approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@nynymike nynymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@moabu moabu merged commit 15e0831 into main Apr 4, 2024
2 checks passed
@moabu moabu deleted the fix-casa-bioid branch April 4, 2024 08:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'jans-core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'orm'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'Fido2 API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'SCIM API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nynymike nynymike nynymike approved these changes

@jgomer2001 jgomer2001 jgomer2001 approved these changes

@maduvena maduvena Awaiting requested review from maduvena maduvena is a code owner

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-agama Touching folder /agama kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-casa): add bioid plugin
5 participants
@SafinWasi @nynymike @jgomer2001 @moabu @mo-auto