-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config-api): asset mgt changes to use document service rather than provider #8324
Conversation
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…ns-config-fixes
Signed-off-by: pujavs <pujas.works@gmail.com>
…ns-config-fixes
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…ns-config-fixes
Signed-off-by: pujavs <pujas.works@gmail.com>
…ns-config-fixes
…n provider Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
updateRevision(asset); | ||
|
||
//get asset | ||
asset = setAssetContent(asset, new Base64InputStream(getInputStream(bos), true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pujavs shouldn't we close input stream ? Not closed steams can cause unreleased resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuriyz have fixed the issue regarding stream closure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, approved
…ns-config-fixes
Signed-off-by: pujavs <pujas.works@gmail.com>
…ns-config-fixes
Signed-off-by: pujavs <pujas.works@gmail.com>
|
|
|
Prepare
Description
Currently config-api uses DBDocumentStoreProvider for asset mgt however since it does not suffice the complete requirement need to use existing DocumentService
Target issue
closes #8319
Implementation Details
Test and Document the changes