Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config-api): asset mgt changes to use document service rather than provider #8324

Merged
merged 18 commits into from
Apr 19, 2024

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Apr 17, 2024

Prepare


Description

Currently config-api uses DBDocumentStoreProvider for asset mgt however since it does not suffice the complete requirement need to use existing DocumentService

Target issue

closes #8319

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…n provider

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs pujavs requested a review from devrimyatar April 17, 2024 07:43
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Apr 17, 2024
devrimyatar
devrimyatar previously approved these changes Apr 17, 2024
@yuriyz yuriyz enabled auto-merge (squash) April 17, 2024 09:34
updateRevision(asset);

//get asset
asset = setAssetContent(asset, new Base64InputStream(getInputStream(bos), true));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pujavs shouldn't we close input stream ? Not closed steams can cause unreleased resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuriyz have fixed the issue regarding stream closure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approved

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Failed Quality Gate failed for 'jans-config-api-parent'

Failed conditions
2 New Vulnerabilities (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yuriyz yuriyz merged commit e06ea14 into main Apr 19, 2024
3 checks passed
@yuriyz yuriyz deleted the jans-config-fixes branch April 19, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(config-api): asset mgt changes to use document service rather than provider
4 participants