Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloud-native): add support for keycloak scheduler #8423

Merged
merged 16 commits into from
May 13, 2024
Merged

feat(cloud-native): add support for keycloak scheduler #8423

merged 16 commits into from
May 13, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 1, 2024

Prepare

Description

Target issue

closes #8420

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

iromli added 3 commits May 1, 2024 02:56
@iromli
feat(cloud-native): add support for keycloak scheduler
60f8ee7 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
feat(cloud-native): add configurable logging
8a14a0a 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
feat: add charts for kc-scheduler
93f45b8 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-feature Issue or PR is a new feature request labels May 1, 2024
iromli and others added 10 commits May 2, 2024 01:06
@iromli
refactor(cloud-native): simplify logging configuration for job
240598f 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
Merge branch 'main' into cn-kc-scheduler
68fa04c
@iromli
chore: add symlink to main entrypoint.sh
61df7c3 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
ci: add docker-jans-kc-scheduler to workflow and dependabot list
ad12c05 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
docs: add docker-jans-kc-scheduler docs
e82573c 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
fix: add missing HostAliases for Helm charts
7ad01a0 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
fix: add hostAliases only if FQDN not registered
33cb99c 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
fix: enable FILE appender-ref to avoid logback status warning
f891312 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
chore: update kc-jans-scheduler
ec35c13 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
Merge branch 'main' into cn-kc-scheduler
50bcc51
@iromli iromli marked this pull request as ready for review May 7, 2024 18:37
@iromli iromli requested a review from moabu as a code owner May 7, 2024 18:37
@iromli
docs: update reference to docker-jans-kc-scheduler docs
dca37f4 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
moabu
moabu requested changes May 8, 2024
View reviewed changes
Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kc-scheudler chart and cron job in the aio should not run unless global.saml.enabled and global.kc-scheduler.enabled is set to true

@iromli
fix(charts): ensure kc-scheduler cronjob is enabled only when kc-sche…
95133f6 
…duler and saml are enabled

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@moabu moabu merged commit abff9b8 into main May 13, 2024
1 of 2 checks passed
@moabu moabu deleted the cn-kc-scheduler branch May 13, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cloud-native): add support for keycloak scheduler
3 participants
@iromli @moabu @mo-auto