Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloud-native): validate cert downloaded from frontend during initialization #8586

Merged
merged 3 commits into from
May 29, 2024
Merged

fix(cloud-native): validate cert downloaded from frontend during initialization #8586

merged 3 commits into from
May 29, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 26, 2024

Prepare

Description

Target issue

closes #8585

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli
fix(cloud-native): validate cert downloaded from frontend during init…
5258a8d 
…ialization

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-configurator kind-bug Issue or PR is a bug in existing functionality labels May 26, 2024
@iromli iromli marked this pull request as ready for review May 28, 2024 20:24
@iromli iromli requested a review from moabu as a code owner May 28, 2024 20:24
@moabu moabu merged commit 50a7577 into main May 29, 2024
2 checks passed
@moabu moabu deleted the cn-cert-validation branch May 29, 2024 09:29
yurem pushed a commit that referenced this pull request May 31, 2024
@iromli @moabu @yurem
fix(cloud-native): validate cert downloaded from frontend during init…
a394444 
…ialization (#8586)

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-configurator kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(cloud-native): validate cert downloaded from frontend during initialization
3 participants
@iromli @moabu @mo-auto