Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-auth-server): do not recognized different agama flows as different acr #8652 #8653

Merged
merged 3 commits into from
Jun 4, 2024
Merged

fix(jans-auth-server): do not recognized different agama flows as different acr #8652 #8653

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fbc1a6
fix(jans-auth-server): do not recognized different agama flows as dif…
yuriyz Jun 4, 2024
feea0a1
Merge branch 'main' into jans-auth-server-8652
yuriyz Jun 4, 2024
791a3f5
Merge branch 'main' into jans-auth-server-8652
moabu Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion jans-auth-server/server/src/main/java/io/jans/as/server/service/SessionIdService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
import java.util.Map.Entry;
import java.util.concurrent.TimeUnit;

import static io.jans.as.server.service.AcrService.isAgama;
import static org.apache.commons.lang.BooleanUtils.isTrue;

/**
Expand Down Expand Up @@ -189,7 +190,8 @@ public SessionId assertAuthenticatedSessionCorrespondsToNewRequest(SessionId ses
}

List<String> acrValuesList = acrValuesList(acrValuesStr);
boolean isAcrChanged = !acrValuesList.isEmpty() && !acrValuesList.contains(sessionAcr);
boolean isAgama = isAgama(sessionAcr) && !acrValuesList.isEmpty() && isAgama(acrValuesList.iterator().next());
boolean isAcrChanged = !acrValuesList.isEmpty() && !acrValuesList.contains(sessionAcr) && !isAgama;
if (isAcrChanged) {
Map<String, Integer> acrToLevel = externalAuthenticationService.acrToLevelMapping();
Integer sessionAcrLevel = Util.asInt(acrToLevel.get(externalAuthenticationService.scriptName(sessionAcr)), -1);
Expand Down