Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-casa): replace Touch Id with PassKey #8676

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

shekhar16
Copy link
Contributor

@shekhar16 shekhar16 commented Jun 7, 2024

Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Copy link

dryrunsecurity bot commented Jun 7, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Sensitive Files Analyzer 0 findings
Authn/Authz Analyzer 0 findings
AppSec Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The changes in this pull request appear to be focused on improving the user experience and security features related to two-factor authentication (2FA) and credential management in the Jans Casa application. The key changes include updating the terminology to align with Apple's latest branding for their PassKey feature, supporting FIDO2 security keys and built-in platform authenticators like Apple's PassKey for 2FA, requiring users to register a minimum number of credentials before enabling 2FA, and providing robust error handling and password strength validation. These changes demonstrate a security-conscious approach to the application's authentication and credential management functionality.

Files Changed:

  • jans-casa/app/src/main/resources/labels/user.properties: This file contains the user interface labels and descriptions related to the 2FA and credential management features in the Jans Casa application. The changes include:
    • Updating the terminology from "Touch ID" to "PassKey" to align with Apple's latest branding.
    • Providing descriptions and instructions for using FIDO2 security keys and built-in platform authenticators like Apple's PassKey for 2FA.
    • Enforcing a minimum credential requirement before users can enable 2FA to prevent them from accidentally locking themselves out of their accounts.
    • Including various error messages and handling for scenarios like credential creation failure, operation cancellation, and unsupported browsers.
    • Incorporating a password strength indicator and validation to encourage users to choose strong passwords.

These changes demonstrate a security-conscious approach to the application's authentication and credential management functionality, which is an important aspect of maintaining the overall security of the Jans Casa application.

Powered by DryRun Security

@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Jun 7, 2024
@mo-auto
Copy link
Member

mo-auto commented Jun 7, 2024

Error: Hi @shekhar16, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@moabu moabu merged commit 6285cca into main Jun 8, 2024
7 checks passed
@moabu moabu deleted the casa/issues/280 branch June 8, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants