-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-lock): extend infrastructure for cedarling #8760
Conversation
Signed-off-by: sokorototo <nyachiengatoto@gmail.com>
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Change Summary (click to expand)The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective. Summary: The code changes in this pull request cover a wide range of updates across multiple files in the The key security-related changes include:
Overall, the changes appear to be focused on strengthening the application's security posture, with a particular emphasis on the management of sensitive data, authentication and authorization mechanisms, and the secure integration of WASM technology. Files Changed:
Powered by DryRun Security |
Signed-off-by: sokorototo <nyachiengatoto@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two main concerns:
- the tests are performing real HTTP requests. This should be done via mocking the HTTP server and responses.
- the tests themselves look incomplete, as they're not doing any comparison or assertions for the expected vs actual output.
Signed-off-by: sokorototo <nyachiengatoto@gmail.com>
Signed-off-by: sokorototo <nyachiengatoto@gmail.com>
Signed-off-by: sokorototo <nyachiengatoto@gmail.com>
Signed-off-by: sokorototo <nyachiengatoto@gmail.com>
Prepare
Implementation Details
Test and Document the changes