Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-linux-setup): disable time zone for pgsql #8766

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

devrimyatar
Copy link
Contributor

closes #8761

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-linux-setup Component affected by issue or PR labels Jun 24, 2024
Copy link

dryrunsecurity bot commented Jun 24, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Authn/Authz Analyzer 0 findings
SQL Injection Analyzer 0 findings
Sensitive Files Analyzer 0 findings
IDOR Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The code changes in this pull request are focused on the configuration file jans-pgsql.properties, which contains the settings for the PostgreSQL database connection used by the Jans application. The key changes include the addition of the db.disable.time-zone=true setting, which disables the use of time zone information in the database connection. While this change may have implications for how the application handles and stores date and time information, it does not appear to introduce any obvious security concerns.

The file also contains several configuration settings related to the database connection pool, such as the maximum number of connections, minimum idle connections, and connection timeout settings. These settings are important for managing the database connection resources and ensuring the application's scalability and performance. Overall, the changes in this pull request appear to be focused on the database configuration and do not seem to introduce any obvious security vulnerabilities. However, it's important to review the changes carefully and ensure that they do not have any unintended consequences or impact the application's overall security posture.

Files Changed:

  • jans-linux-setup/jans_setup/templates/jans-pgsql.properties: This file contains the configuration settings for the PostgreSQL database connection used by the Jans application. The key changes in this pull request include the addition of the db.disable.time-zone=true setting, which disables the use of time zone information in the database connection, and several existing configuration settings related to the database connection pool.

Powered by DryRun Security

@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Jun 24, 2024
Copy link

sonarcloud bot commented Jun 24, 2024

@yuriyz yuriyz enabled auto-merge (squash) June 24, 2024 09:52
@yuriyz yuriyz merged commit c76b181 into main Jun 25, 2024
10 checks passed
@yuriyz yuriyz deleted the jans-linux-setup-disable-time-zone-for-pgsql-8761 branch June 25, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-ce-setup): add PostgreSQL ORM option to disable use time zone in date/time columns
4 participants