Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(logging): add schema format and example #8796

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

ossdhaval
Copy link
Contributor

Prepare


Description

Target issue

closes #issue-number-here

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
@ossdhaval ossdhaval self-assigned this Jun 27, 2024
Copy link

dryrunsecurity bot commented Jun 27, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Authn/Authz Analyzer 0 findings
SQL Injection Analyzer 0 findings
Sensitive Files Analyzer 0 findings
IDOR Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The code change in this pull request focuses on updating the logging configuration for the Janssen Authorization Server. The key changes include providing details on how to manage the logging configuration using different methods (command-line, text-based UI, and REST API), as well as outlining the schema for the Logging configuration. From a security perspective, the notable aspects of this change are the ability to configure the logging level, enable or disable OAuth audit logging, and exclude specific HTTP paths from being logged. These features are important for controlling the amount of sensitive information being logged and reducing the risk of exposing sensitive data.

Files Changed:

  • docs/admin/config-guide/logging-configuration.md: This file has been updated to provide comprehensive documentation on managing the logging configuration for the Janssen Authorization Server. The changes include:
    1. Detailed information on how to manage the logging configuration using different methods (command-line, text-based UI, and REST API).
    2. Explanation of the logging configuration schema, including properties like loggingLevel, httpLoggingEnabled, enabledOAuthAuditLogging, and httpLoggingExcludePaths.
    3. Guidance on how to update the logging configuration by modifying the log-config.json file and using the put-config-logging operation.
    4. Highlighting the security-relevant aspects of the logging configuration, such as controlling the logging level, enabling or disabling OAuth audit logging, and excluding specific HTTP paths from being logged.

These changes provide a clear and comprehensive guide for administrators to manage the logging configuration of the Janssen Authorization Server, with a focus on maintaining the security and integrity of the system.

Powered by DryRun Security

@mo-auto mo-auto added the area-documentation Documentation needs to change as part of issue or PR label Jun 27, 2024
@mo-auto mo-auto enabled auto-merge (squash) June 27, 2024 11:12
@ossdhaval ossdhaval requested a review from maduvena June 27, 2024 11:15
@mo-auto mo-auto merged commit 14bf29d into main Jun 27, 2024
9 checks passed
@mo-auto mo-auto deleted the logging-configuration-update branch June 27, 2024 17:10
yurem pushed a commit that referenced this pull request Jun 27, 2024
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants