Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-keycloak-integration): update kc saml integration into ce and cn #8776 #8806

Merged
merged 48 commits into from
Jun 28, 2024

Conversation

uprightech
Copy link
Contributor

@uprightech uprightech commented Jun 28, 2024

Closes issue #8776
Closes #8807,

* updated the keycloak configuration file to reflect the  configuration for the storage-spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
… persistence layer

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…8614

* added persistence manager configuration for protocol mapper

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
#8614

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added dependencies to protocol mapper
* added protocol mapper main class

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added relevant models to fetch user attributes
* refactored the db configuration classes

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* created maven project for janssen spi bundle

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added dependencies xml

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* added support for new protocol mapper in job scheduler
* fixed typo in application shutdown log message

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>


* added support for the protocol-mapper in job-scheduler configuration
* fixed issue in  job-scheduler logging configuration that caused too many log files to be created

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
* additions to the spi bundle pom file

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>


* added protocol mapper implementation

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* added thin bridge spi provider
* added models for thin bridge provider

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* moved authenticator spi to spi module
* minor refactoring to the authenticator spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* moved authenticator rest service spi to spi module

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* added new storage provider implementation

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* added missing files to spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* added resource files to spi module

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* bump spi version to 1.1.3-SNAPSHOT
* removed protocol-mapper PoC from build modules

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* minor bugfix to scheduler. did not show fatal startup errors in log file

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

*fix for fatal errors which don't still appear in the logs

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* further housekeeping in job-scheduler

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* fixed bug in user storage spi preventing authentication in new version of keycloak

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* have scheduler create saml clients with document and assertion signing as default configuration

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…tion #8614

* removed reference to protocol-mapper poc submodule

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* removed reference to storage-spi module
* restored job-scheduler module in build pom

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* removed authenticator source as it was moved to spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

* fixes suggested by static analyser

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ation #8614

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ion for ce and cn #8776

* marked jans  authenticator in the kc authentication flow ALTERNATIVE
* updated providerId for our custom user storage provider

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ion for ce and cn #8776

* bump keycloak version in setup to 25.0.1

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ion for ce and cn #8776

* removed references to scim client configuration reference (used by former user storage provider)

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ion for ce and cn #8776

* moved kc service configuration parameters from service file to keycloak configuration file

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…ion for ce and cn #8776

* added quarkus.properties
* minor change to keycloak service file

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…k libs version #8776

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Copy link

dryrunsecurity bot commented Jun 28, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Authn/Authz Analyzer 1 finding
SQL Injection Analyzer 0 findings
Sensitive Files Analyzer 1 finding
IDOR Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The code changes in this pull request are focused on updating the dependencies and improving the security of the authentication completion process in the Jans Keycloak integration project.

The first change adds a new dependency to the pom.xml file for the resteasy-reactive library, which is a part of the JBoss ecosystem. This change is not immediately concerning from a security perspective, but it's important to review the new dependency to ensure that it is being used securely and that there are no known vulnerabilities associated with it.

The second change is related to the JansAuthResponseResourceProvider class, which is responsible for handling the completion of the authentication process in the Keycloak realm. The changes include updates to the import statements, as well as improvements to the completeAuthentication method, which performs crucial security checks and validations to ensure the integrity of the authentication flow and protect against potential security vulnerabilities.

Overall, these code changes appear to be routine updates and security enhancements, and there are no obvious security concerns that need to be addressed. However, it's important to continue monitoring the project's code changes and dependencies to ensure the ongoing security of the application.

Files Changed:

  1. jans-keycloak-integration/spi/pom.xml:

    • Added a new dependency for the resteasy-reactive library.
  2. jans-keycloak-integration/spi/src/main/java/io/jans/kc/spi/rest/JansAuthResponseResourceProvider.java:

    • Updated the import statement for the NoCache annotation to use the Resteasy Reactive framework.
    • Improved the completeAuthentication method by performing checks on the realm, action URI, and storing the authentication results securely.
    • Implemented safeguards to ensure the integrity of the authentication flow and protect against potential security vulnerabilities.

Powered by DryRun Security

@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Jun 28, 2024
@mo-auto
Copy link
Member

mo-auto commented Jun 28, 2024

Error: Hi @uprightech, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@yurem yurem enabled auto-merge (squash) June 28, 2024 09:53
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'keycloak-integration-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yurem yurem merged commit 8d4251a into main Jun 28, 2024
10 checks passed
@yurem yurem deleted the issue_8776 branch June 28, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: feat(jans-keycloak-integration): update kc saml integration into ce and cn #8776 -autocreated
4 participants