Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-linux-setup): status list must be enabled during tests #8838 #8839

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

yuriyz
Copy link
Contributor

@yuriyz yuriyz commented Jul 3, 2024

Description

feat(jans-linux-setup): status list must be enabled during tests #8838

Target issue

closes #8838

  • I confirm that there is no impact on the docs due to the code changes in this PR.

#8838
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
Copy link

dryrunsecurity bot commented Jul 3, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Authn/Authz Analyzer 0 findings
SQL Injection Analyzer 0 findings
Sensitive Files Analyzer 0 findings
IDOR Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The code changes in this pull request are focused on improving the test suite for the Jans Authentication Server. The changes include:

  1. Enhancing the error handling in the BaseTest.java file to provide more information when a required element is not found within the specified timeout. This change is intended to improve the debugging and troubleshooting capabilities of the test suite.

  2. Updating the logging statements in the StatusListHttpTest.java file to make the test output more descriptive. The main functionality of the statusList test method remains the same, verifying the token status list functionality of the Jans Auth Server.

  3. Modifying the test_data_loader.py file in the jans-linux-setup project to load test data for the Jans Authentication Server. This includes updating the oxAuth configuration, loading LDIF files, deploying test client keys, and enabling custom scripts and LDAP schema changes.

From an application security perspective, these changes do not introduce any significant security concerns. The updates are focused on improving the test suite and the test data setup, which can help identify and address potential security vulnerabilities more effectively. However, it is important to ensure that the test data and environment are properly isolated from the production environment and that any security-related configurations are reviewed and validated.

Files Changed:

  1. jans-auth-server/client/src/test/java/io/jans/as/client/BaseTest.java: The change adds error handling to the waitForRequredElementLoad method, providing more information when the required element is not found within the specified timeout.

  2. jans-auth-server/client/src/test/java/io/jans/as/client/ws/rs/token/StatusListHttpTest.java: The changes update the logging statements to include more descriptive information, but the main functionality of the statusList test method remains the same.

  3. jans-linux-setup/jans_setup/setup_app/test_data_loader.py: The changes in this file are focused on loading test data for the Jans Authentication Server, including updating the oxAuth configuration, loading LDIF files, deploying test client keys, and enabling custom scripts and LDAP schema changes.

Powered by DryRun Security

@yuriyz yuriyz enabled auto-merge (squash) July 3, 2024 09:38
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Jul 3, 2024
Copy link

sonarcloud bot commented Jul 3, 2024

@yuriyz yuriyz merged commit ca7e04c into main Jul 3, 2024
10 checks passed
@yuriyz yuriyz deleted the jans-linux-setup-8838 branch July 3, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-linux-setup): status list must be enabled during tests
4 participants