Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add docs check to make sure every PR is doc checked #8842

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

moabu
Copy link
Member

@moabu moabu commented Jul 3, 2024

Prepare


Description

Target issue

closes #8841

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Closes #8843,

Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Copy link

dryrunsecurity bot commented Jul 3, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Authn/Authz Analyzer 0 findings
SQL Injection Analyzer 0 findings
Sensitive Files Analyzer 0 findings
IDOR Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The provided changes focus on the implementation of a pull request (PR) template and a GitHub Actions workflow to ensure that documentation changes are properly identified and communicated in the PR process.

The PR template includes several security-related checklist items, such as verifying that relevant unit and integration tests have been added or updated, and confirming that there is no impact on the documentation due to the code changes. These practices help maintain the security and integrity of the codebase.

The GitHub Actions workflow is designed to automatically check for documentation changes in pull requests. It verifies the commit message and the PR body to ensure that the PR author has acknowledged any documentation changes. This workflow helps to identify and manage sensitive information that may be present in the documentation, which is an important security consideration.

Overall, these changes demonstrate a proactive approach to maintaining the security and quality of the project's codebase and documentation. The inclusion of security-focused checklist items and the automated workflow for documentation changes are positive steps towards enhancing the overall security posture of the application.

Files Changed:

  1. .github/pull_request_template.md:

    • This file contains the pull request template for the Janssen Project repository.
    • The template includes several checklist items related to security, such as ensuring relevant tests have been added/updated and confirming that there is no impact on the documentation.
    • These practices help maintain the security and integrity of the codebase.
  2. .github/workflows/documenation_check.yml:

    • This GitHub Actions workflow is designed to check for documentation changes in pull requests.
    • The workflow is triggered when a new PR is opened or edited and verifies the commit message and PR body to ensure that the PR author has acknowledged any documentation changes.
    • This workflow helps to identify and manage sensitive information that may be present in the documentation, which is an important security consideration.

Powered by DryRun Security

@moabu moabu merged commit c0154b3 into main Jul 3, 2024
9 checks passed
@moabu moabu deleted the ci-add-docs-check branch July 3, 2024 11:25
@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure area-documentation Documentation needs to change as part of issue or PR labels Jul 3, 2024
@mo-auto
Copy link
Member

mo-auto commented Jul 3, 2024

Error: Hi @moabu, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure area-documentation Documentation needs to change as part of issue or PR
Projects
None yet
2 participants