Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): prep work for 1.1.4-SNAPSHOT and dev #8895

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

moabu
Copy link
Member

@moabu moabu commented Jul 8, 2024

Prepare

Chore changes for 1.1.4 preperations

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Copy link

dryrunsecurity bot commented Jul 8, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Secrets Analyzer 0 findings
Authn/Authz Analyzer 0 findings
SQL Injection Analyzer 0 findings
Sensitive Files Analyzer 2 findings
IDOR Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The provided code changes cover a wide range of updates to the Janssen project, including version bumps for various Helm charts, image tag updates, and changes to configuration files. From an application security perspective, the changes do not appear to introduce any immediate security concerns, but there are several areas that require careful review to ensure the ongoing security and integrity of the application.

Key security considerations include:

  1. Dependency and Version Management: Ensure that all updated dependencies and versions do not contain any known security vulnerabilities. Review release notes and security advisories for the new versions.
  2. Sensitive Data Handling: Review the handling of sensitive information, such as credentials, API keys, and other secrets, to ensure they are properly secured and not exposed in the configuration or deployment.
  3. Health Checks and Probes: Verify that the health check and probe configurations do not expose any sensitive information or introduce potential vulnerabilities.
  4. Resource Allocation: Ensure that the resource limits and requests are appropriate to prevent potential denial-of-service attacks or resource exhaustion issues.
  5. Secure Integration: Review the integration with external services, such as Google Secret Manager and Hashicorp Vault, to ensure proper authentication, authorization, and secure communication.

Overall, the changes appear to be routine updates, but it is crucial to thoroughly review them to maintain the application's security posture.

Files Changed:

  1. agama/pom.xml: Version update for the agama project.
  2. charts/janssen-all-in-one/Chart.yaml: Version update for the Janssen All-in-One Helm chart, including a mention of security updates.
  3. agama/transpiler/pom.xml: Version update for the agama-transpiler module.
  4. .github/workflows/build-docs.yml: Updates to the GitHub Actions workflow for building and publishing Janssen Project documentation.
  5. charts/janssen-all-in-one/README.md: Version update for the Janssen All-in-One Helm chart.
  6. charts/janssen/Chart.yaml: Version update for the Janssen Helm chart.
  7. charts/janssen/charts/auth-server-key-rotation/Chart.yaml: Version update for the auth-server-key-rotation Helm chart.
  8. charts/janssen/charts/auth-server-key-rotation/README.md: Version update for the auth-server-key-rotation Helm chart.
  9. charts/janssen/charts/auth-server/Chart.yaml: Version update for the auth-server Helm chart.
  10. charts/janssen/charts/auth-server/README.md: Version update for the auth-server Helm chart.
  11. charts/janssen/charts/auth-server/values.yaml: Image tag update for the auth-server service.
  12. charts/janssen/charts/casa/Chart.yaml: Version update for the casa Helm chart.
  13. charts/janssen/charts/casa/README.md: Version update for the casa Helm chart.
  14. charts/janssen/charts/casa/values.yaml: Image tag update for the Jans Casa application.
  15. charts/janssen/charts/config/Chart.yaml: Version update for the config Helm chart.
  16. charts/janssen/charts/config-api/Chart.yaml: Version update for the config-api Helm chart.
  17. charts/janssen/charts/config-api/README.md: Version update for the config-api Helm chart.
  18. charts/janssen/charts/config-api/values.yaml: Image tag update for the config-api service.
  19. charts/janssen/charts/config/values.yaml: Image tag update for the Janssen Configurator.
  20. charts/janssen/charts/config/README.md: Version update for the config Helm chart.
  21. charts/janssen/charts/kc-scheduler/Chart.yaml: Version update for the kc-scheduler Helm chart.
  22. charts/janssen/charts/kc-scheduler/README.md: Version update for the kc-scheduler Helm chart.
  23. charts/janssen/charts/fido2/Chart.yaml: Version update for the fido2 Helm chart.
  24. charts/janssen/charts/fido2/README.md: Version update for the fido2

Powered by DryRun Security

yurem
yurem previously approved these changes Jul 8, 2024
Copy link

sonarcloud bot commented Jul 8, 2024

Copy link

sonarcloud bot commented Jul 8, 2024

Copy link

sonarcloud bot commented Jul 8, 2024

uprightech
uprightech previously approved these changes Jul 8, 2024
pujavs
pujavs previously approved these changes Jul 8, 2024
@yurem yurem enabled auto-merge (squash) July 8, 2024 15:23
jgomer2001
jgomer2001 previously approved these changes Jul 8, 2024
yuriyz
yuriyz previously approved these changes Jul 8, 2024
iromli
iromli previously approved these changes Jul 8, 2024
shekhar16
shekhar16 previously approved these changes Jul 8, 2024
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Copy link

dryrunsecurity bot commented Jul 9, 2024

DryRun Security Summary

The provided code changes appear to be a series of routine updates to the Janssen Project's Helm charts and associated components, primarily involving version updates, image tag changes, and minor configuration adjustments, which require careful review to ensure no unintended security vulnerabilities are introduced.

Expand for full summary

Summary:

The provided code changes appear to be a series of routine updates to the Janssen Project's Helm charts and associated components. The changes primarily involve version updates, image tag changes, and minor configuration adjustments. While there are no obvious security concerns with these changes, it's important to review them carefully to ensure that no unintended security vulnerabilities are introduced.

Key areas to focus on include:

  1. Version Updates: Ensure that the new versions of the components and Helm charts do not contain any known security vulnerabilities or introduce breaking changes that could impact the application's security posture.
  2. Image Tag Changes: Verify that the new image tags correspond to trusted and secure versions of the application components, and that the images have been properly scanned and vetted for security issues.
  3. Sensitive Configuration: Review any changes to sensitive configuration parameters, such as database credentials, API keys, and other secrets, to ensure they are properly secured and not exposed.
  4. Healthcheck and Probe Configuration: Ensure that the liveness and readiness probes are properly configured and do not expose any sensitive information or introduce potential vulnerabilities.
  5. Custom Scripts and Environment Variables: Carefully review any changes that allow for the addition of custom scripts or environment variables, as these could potentially introduce security risks if not properly validated and secured.

Overall, the changes in this pull request appear to be routine updates, but it's essential to thoroughly review them and test the updated application in a non-production environment to verify that there are no security-related issues or regressions.

Files Changed:

  1. agama/pom.xml: The version of the agama project has been updated from 1.1.3 to 1.1.4-SNAPSHOT.
  2. agama/transpiler/pom.xml: The parent project's version has been updated from 1.1.3 to 1.1.4-SNAPSHOT.
  3. .github/workflows/test_docker_linux_installer.yml: The workflow for testing the Linux installer for the Janssen Project has been updated.
  4. .github/workflows/build-docs.yml: The workflow for publishing the Janssen Project documentation has been updated.
  5. charts/janssen-all-in-one/Chart.yaml: The Docker image tag and app version for the Janssen All-in-One deployment have been updated.
  6. automation/startjanssenmonolithdemo.sh: The script for setting up and managing the Janssen monolith demo environment has been updated.
  7. charts/janssen-all-in-one/README.md: The version information in the Janssen All-in-One Helm chart README has been updated.
  8. charts/janssen/Chart.yaml: The image tags for various Janssen microservices have been updated to 1.1.4_dev.
  9. charts/janssen/charts/auth-server-key-rotation/Chart.yaml: The version of the auth-server-key-rotation chart has been updated to 1.1.4-dev.
  10. charts/janssen/charts/auth-server-key-rotation/values.yaml: The image tag for the certmanager container has been updated to 1.1.4_dev.
  11. charts/janssen/charts/auth-server/Chart.yaml: The version of the auth-server chart has been updated to 1.1.4-dev.
  12. charts/janssen/charts/auth-server/README.md: The version information in the auth-server chart README has been updated.
  13. charts/janssen/charts/auth-server/values.yaml: The Docker image tag for the auth-server component has been updated to 1.1.4_dev.
  14. charts/janssen/charts/casa/Chart.yaml: The version of the casa chart has been updated to 1.1.4-dev.
  15. charts/janssen/charts/casa/README.md: The version and image tag information in the casa chart README has been updated.
  16. charts/janssen/charts/casa/values.yaml: The Docker image tag for the casa component has been updated to 1.1.4_dev.
  17. charts/janssen/charts/config-api/Chart.yaml: The version of the config-api chart has been updated to 1.1.4-dev.
  18. `charts/jan

Code Analysis

We ran 7 analyzers against 30 files and 1 analyzer had findings. 6 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 2 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@moabu moabu disabled auto-merge July 9, 2024 10:06
@moabu moabu merged commit b8f44db into main Jul 9, 2024
9 checks passed
@moabu moabu deleted the release-1.1.4-snapshot branch July 9, 2024 10:06
moabu added a commit to GluuFederation/flex that referenced this pull request Jul 11, 2024
…enProject/jans#8895

Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
moabu added a commit to GluuFederation/flex that referenced this pull request Jul 11, 2024
…enProject/jans#8895 (#1767)

Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants