ci: fix override on running tests and registered FQDN

[moabu]

Prepare

• Read PR guidelines
• Read license information

---

Description

Target issue

closes #8914

Implementation Details

---

Test and Document the changes

• Static code analysis has been run locally and issues have been fixed
• Relevant unit and integration tests have been added/updated
• Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

• I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #8926,

[dryrunsecurity]

DryRun Security Summary

The pull request focuses on updating the GitHub Actions workflow and the startjanssenmonolithdemo.sh script to improve the setup and testing of the Janssen monolith demo application, with a review of potential security considerations, particularly regarding the use of the JANS_INSECURE_CLIENT environment variable.

Expand for full summary

Summary:

The code changes in this pull request are primarily focused on updating the GitHub Actions workflow and the startjanssenmonolithdemo.sh script, which are responsible for setting up and testing the Janssen monolith demo application. From an application security perspective, the changes do not introduce any obvious security vulnerabilities, but there are a few areas that should be reviewed to ensure the overall security of the application.

The GitHub Actions workflow update includes changes to the "Test Jans monolith demo" step, where the RUN_TESTS=true environment variable is now set directly in the sudo command instead of being set as a separate export statement. Additionally, the use of the JANS_INSECURE_CLIENT=true environment variable should be reviewed to ensure that it is only used for testing purposes and not in production environments.

The changes to the startjanssenmonolithdemo.sh script focus on improving the script's functionality and flexibility, such as initializing variables, installing dependencies, handling the monorepo, and selecting the appropriate persistence type. While these changes do not directly introduce security concerns, it's important to review the dependencies and ensure that the application is properly secured, especially when using the JANS_INSECURE_CLIENT environment variable.

Files Changed:

1. .github/workflows/test_docker_linux_installer.yml:

   • Changes made to the "Test Jans monolith demo" step, where the RUN_TESTS=true environment variable is now set directly in the sudo command.
   • The use of the JANS_INSECURE_CLIENT=true environment variable should be reviewed to ensure it is only used for testing purposes.

2. automation/startjanssenmonolithdemo.sh:

   • Variable initialization using the ${variable:=} syntax to handle cases where variables are not provided.
   • Installation of necessary dependencies, including Docker, Docker Compose, and various Python libraries.
   • Handling of the Janssen monorepo using Git's sparse checkout feature.
   • Modifications to the Dockerfile and Docker Compose files to use the specified Git commit.
   • Injection of environment variables into the Dockerfile and Docker Compose files.
   • Support for different persistence types (LDAP, MySQL, PostgreSQL).
   • Health checks and testing functionality to verify the correct functioning of the demo environment.

Code Analysis

We ran 7 analyzers against 2 files and 0 analyzers had findings. 7 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[mo-auto]

Error: Hi @moabu, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.