Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use test containers to be consistent with other testing frameworks. #12

Closed
jackson-chris opened this issue Jul 9, 2020 · 0 comments
Closed

Use test containers to be consistent with other testing frameworks. #12

jackson-chris opened this issue Jul 9, 2020 · 0 comments
Milestone
first release

Comments

@jackson-chris
Copy link
Contributor

For consistency purposes and ease of use we should adopt test containers. The current compose testing framework doesn't work out of the box on mac, and needs to be pulled from a non central repository.
jackson-chris added a commit to jackson-chris/janusgraph-foundationdb that referenced this issue Jul 10, 2020
@jackson-chris
JanusGraph#12. Use testcontainers instead of compose. Use org.foundat…
2eb10ef 
…iondb artifacts and latest fdb image
jackson-chris added a commit to jackson-chris/janusgraph-foundationdb that referenced this issue Jul 10, 2020
@jackson-chris
JanusGraph#12. Use testcontainers instead of compose. Use org.foundat…
8726b55 
…iondb artifacts and latest fdb image
jackson-chris added a commit to jackson-chris/janusgraph-foundationdb that referenced this issue Jul 10, 2020
@jackson-chris
JanusGraph#12. Use testcontainers instead of compose. Use org.foundat…
a50ba8b 
…iondb artifacts and latest fdb image
jackson-chris added a commit to jackson-chris/janusgraph-foundationdb that referenced this issue Jul 10, 2020
@jackson-chris
JanusGraph#12. Use testcontainers instead of compose. Use org.foundat…
b26f5fc 
…iondb artifacts and latest fdb image

Signed-off-by: Christopher Jackson <jackson.christopher.lee@gmail.com>
jackson-chris added a commit to jackson-chris/janusgraph-foundationdb that referenced this issue Jul 10, 2020
@jackson-chris
JanusGraph#12. Use testcontainers instead of compose. Use org.foundat…
f3a1478 
…iondb artifacts and latest fdb image

Signed-off-by: Christopher Jackson <chris.jackson@us.ibm.com>
jackson-chris added a commit to jackson-chris/janusgraph-foundationdb that referenced this issue Jul 16, 2020
@jackson-chris
JanusGraph#12. Use testcontainers instead of compose. Use org.foundat…
6550d34 
…iondb artifacts and latest fdb image

Signed-off-by: Christopher Jackson <chris.jackson@us.ibm.com>
@farodin91 farodin91 added this to the first release milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
first release
Development

No branches or pull requests
2 participants
@jackson-chris @farodin91