New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract JanusGraph Gremlin driver requirements #1521
Extract JanusGraph Gremlin driver requirements #1521
Conversation
ff41bea
to
f0bde96
Compare
f0bde96
to
d890293
Compare
d890293
to
aae60c8
Compare
@farodin91 I will try to review it this week |
aae60c8
to
2f21a7d
Compare
I don't want to fix all codacy issue to prevent any major changes. |
That is OK but I think at least CI build should pass |
17e4466
to
5c631cd
Compare
@porunov I did break something by rebasing. |
5c631cd
to
7ec4d1f
Compare
3ce0343
to
52f0d7f
Compare
* Predicates * Geoshape * RelationIdenitifier Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
52f0d7f
to
0791bc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally I have reviewed all the code in this PR. All code LGTM. Thank you for moving it to janusgraph-driver, also thank you for some additional refactoring.
Even so it looks like everything should work, I would like to execute TinkerPop tests for all big PRs.
I've started TP tests for current master branch with merged this PR into it. I will post a result in about 15 hours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @farodin91 .
All TP tests passed.
@porunov I merged it locally using fast forward |
Support things
ToDo:
Signed-off-by: Jan Jansen jan.jansen@gdata.de
Discussion on google groups: https://groups.google.com/forum/#!topic/janusgraph-dev/nmdEk_uGxdI
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes:
[skip ci]
tag to the first line of your commit message to avoid spending CPU cycles in
Travis CI when no code, tests, or build configuration are modified?
Note:
Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.
Any thoughts?