Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CQL config to allow disabling TTL #3400

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Add CQL config to allow disabling TTL #3400

merged 2 commits into from
Dec 20, 2022

Conversation

li-boxuan
Copy link
Member

AWS keyspace by default does not support TTL, although it can be turned on. When TTL
support is off, we should let users disable TTL from JanusGraph as well, otherwise
they could see errors like InvalidQueryException: TTL is not yet supported.

This also removes timestamps(false) annotation for DefaultPartitioner.
That was most likely a mistake.

Fixes #3395

Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@li-boxuan
Amazon Keyspace: Add hint on full-scan
950f18a 
This commit improves the doc for Amazon Keyspace usage, including:
1. Add hint on the potential problem of doing full-scan
2. Include a list of all available partition names
3. Change default partitioner to the current Amazon default one

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
@li-boxuan
Add CQL config to allow disabling TTL
fe0e964 
AWS keyspace by default does not support TTL, although it can be turned on. When TTL
support is off, we should let users disable TTL from JanusGraph as well, otherwise
they could see errors like `InvalidQueryException: TTL is not yet supported`.

This also removes timestamps(false) annotation for DefaultPartitioner.
That was most likely a mistake.

Fixes JanusGraph#3395

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
@li-boxuan li-boxuan added this to the Release v1.0.0 milestone Dec 18, 2022
@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Dec 18, 2022
@li-boxuan
Copy link
Member Author

C.C. @abhirj87 for awareness

porunov
porunov approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @li-boxuan !

@li-boxuan li-boxuan merged commit 6964a61 into JanusGraph:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porunov porunov porunov approved these changes

Assignees
No one assigned
Labels
cla: external Externally-managed CLA
Projects
None yet
Milestone
Release v1.0.0
Development

Successfully merging this pull request may close these issues.

Add CQL config option to indicate whether TTL is enabled
3 participants
@li-boxuan @porunov @janusgraph-bot