Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused JanusGraphMultiQueryStep when possible [tp-tests][cql-tests] #3743

Merged

Conversation

porunov
Copy link
Member

@porunov porunov commented Apr 26, 2023

Fixes #3737


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@porunov porunov added this to the Release v1.0.0 milestone Apr 26, 2023
@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Apr 26, 2023
…ests]

Fixes JanusGraph#3737

Signed-off-by: Oleksandr Porunov <alexandr.porunov@gmail.com>
@porunov porunov force-pushed the feature/remove-unused-multi-query branch from b1d5e52 to c420d96 Compare April 26, 2023 13:02
@porunov porunov changed the title Remove unused JanusGraphMultiQueryStep when possible Remove unused JanusGraphMultiQueryStep when possible [tp-tests][cql-tests] Apr 26, 2023
@porunov
Copy link
Member Author

porunov commented Apr 26, 2023

For some reason TP tests were not executed in this PR even so I added [tp-tests] into the commit message.
Nevertheless master branch have a bug executing TP tests, thus they won't pass here anyways. See: #3747

@porunov porunov requested a review from a team April 27, 2023 17:25
@porunov
Copy link
Member Author

porunov commented May 3, 2023

I have intention of merging this PR via lazy consensus. The new behavior can be disabled if JanusGraphUnusedMultiQueryRemovalStrategy is excluded from the traversal.

@porunov porunov merged commit f0e6676 into JanusGraph:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA
Projects
2 participants