Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group CQL keys into a single query [cql-tests] [tp-tests] #3879

Merged
merged 1 commit into from
Aug 4, 2023

Group CQL same token range keys into a single query [cql-tests] [tp-t…

a069074
Select commit
Loading
Failed to load commit list.
Merged

Group CQL keys into a single query [cql-tests] [tp-tests] #3879

Group CQL same token range keys into a single query [cql-tests] [tp-t…
a069074
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis succeeded Aug 4, 2023 in 0s

Your pull request is up to standards!

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 5
- Added 11
           

Complexity increasing per file
==============================
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/strategy/TokenRangeAwareGroupedExecutionStrategy.java  9
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/strategy/ReplicasAwareGroupedExecutionStrategy.java  8
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/util/KeysGroup.java  1
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/strategy/GroupedExecutionStrategyBuilder.java  13
- janusgraph-cql/src/test/java/org/janusgraph/diskstorage/cql/strategy/GroupedExecutionStrategyBuilderTest.java  2
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/service/GroupingAsyncQueryExecutionService.java  6
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/function/slice/AsyncCQLSingleKeySliceFunction.java  1
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/function/slice/AsyncCQLMultiKeyMultiColumnFunction.java  1
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/query/MultiKeysSingleSliceQuery.java  1
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/query/MultiKeysMultiColumnQuery.java  1
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/query/SingleKeyMultiColumnQuery.java  1
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/QueryGroups.java  1
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/util/CQLSliceQueryUtil.java  7
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/function/slice/AsyncCQLSingleKeyMultiColumnFunction.java  1
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/function/slice/AsyncCQLMultiKeySliceFunction.java  1
- janusgraph-core/src/main/java/org/janusgraph/diskstorage/util/CompletableFutureUtil.java  2
- janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLColValGetter.java  3
         

Complexity decreasing per file
==============================
+ janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java  -4

See the complete overview on Codacy

Annotations

Check warning on line 77 in janusgraph-core/src/main/java/org/janusgraph/diskstorage/util/CompletableFutureUtil.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-core/src/main/java/org/janusgraph/diskstorage/util/CompletableFutureUtil.java#L77 

Use equals() to compare object references.

Check warning on line 757 in janusgraph-core/src/main/java/org/janusgraph/diskstorage/util/StaticArrayEntryList.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-core/src/main/java/org/janusgraph/diskstorage/util/StaticArrayEntryList.java#L757 

Avoid reassigning parameters such as 'startPos'

Check notice on line 153 in janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java#L153 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 154 in janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java#L154 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 154 in janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java#L154 

Perhaps 'multiKeysGetter' could be replaced by a local variable.

Check notice on line 165 in janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java#L165 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 45 in janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/strategy/ReplicasAwareGroupedExecutionStrategy.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/strategy/ReplicasAwareGroupedExecutionStrategy.java#L45 

Avoid unused constructor parameters such as 'configuration'.

Check warning on line 44 in janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/strategy/TokenRangeAwareGroupedExecutionStrategy.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/strategy/TokenRangeAwareGroupedExecutionStrategy.java#L44 

Avoid unused constructor parameters such as 'configuration'.

Check warning on line 79 in janusgraph-cql/src/test/java/org/janusgraph/diskstorage/cql/strategy/GroupedExecutionStrategyBuilderTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/test/java/org/janusgraph/diskstorage/cql/strategy/GroupedExecutionStrategyBuilderTest.java#L79 

Avoid unused constructor parameters such as 'configuration'.

Check warning on line 105 in janusgraph-cql/src/test/java/org/janusgraph/diskstorage/cql/strategy/GroupedExecutionStrategyBuilderTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/test/java/org/janusgraph/diskstorage/cql/strategy/GroupedExecutionStrategyBuilderTest.java#L105 

Avoid unused constructor parameters such as 'configuration'.

Check warning on line 106 in janusgraph-cql/src/test/java/org/janusgraph/diskstorage/cql/strategy/GroupedExecutionStrategyBuilderTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cql/src/test/java/org/janusgraph/diskstorage/cql/strategy/GroupedExecutionStrategyBuilderTest.java#L106 

Avoid throwing raw exception types.
View more details on Codacy Production