Issue 87 - Hadoop InputFormat tests should check property values #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue 87. first PR. thanks for reviewing |
|
Fixes #87 |
jerryjch
changed the title
sjudeng
approved these changes
Sep 9, 2017
mbrukman
reviewed
Sep 9, 2017
| @@ -70,12 +70,18 @@ public void testReadWideVertexWithManyProperties() throws Exception { | |||
| Map<String, Object> propertiesOnVertex = graph.traversal().V().valueMap().next(); | |||
| List<?> valuesOnP = (List)propertiesOnVertex.values().iterator().next(); | |||
| assertEquals(numProps, valuesOnP.size()); | |||
| for (int i=0;i< numProps; i++) { | |||
| assertEquals(Integer.toString(i), valuesOnP.get(i).toString() ); | |||
There was a problem hiding this comment.
Please delete extra space before closing parenthesis.
There was a problem hiding this comment.
I will fix it too. thx
| Graph g = getGraph(); | ||
| GraphTraversalSource t = g.traversal(GraphTraversalSource.computer(SparkGraphComputer.class)); | ||
| assertEquals(numV, (long) t.V().count().next()); | ||
| propertiesOnVertex = t.V().valueMap().next(); | ||
| valuesOnP = (List)propertiesOnVertex.values().iterator().next(); | ||
| assertEquals(numProps, valuesOnP.size()); | ||
| for (int i=0;i< numProps; i++) { | ||
| assertEquals(Integer.toString(i), valuesOnP.get(i).toString() ); |
There was a problem hiding this comment.
Please delete extra space before closing parenthesis.
| @@ -70,12 +70,18 @@ public void testReadWideVertexWithManyProperties() throws Exception { | |||
| Map<String, Object> propertiesOnVertex = graph.traversal().V().valueMap().next(); | |||
| List<?> valuesOnP = (List)propertiesOnVertex.values().iterator().next(); | |||
| assertEquals(numProps, valuesOnP.size()); | |||
| for (int i=0;i< numProps; i++) { | |||
There was a problem hiding this comment.
For consistency and readability, please format with spaces around = and < and space after ;:
for (int i = 0; i < numProps; i++) {There was a problem hiding this comment.
thanks for the comment. I will fix it
| Graph g = getGraph(); | ||
| GraphTraversalSource t = g.traversal(GraphTraversalSource.computer(SparkGraphComputer.class)); | ||
| assertEquals(numV, (long) t.V().count().next()); | ||
| propertiesOnVertex = t.V().valueMap().next(); | ||
| valuesOnP = (List)propertiesOnVertex.values().iterator().next(); | ||
| assertEquals(numProps, valuesOnP.size()); | ||
| for (int i=0;i< numProps; i++) { |
There was a problem hiding this comment.
For consistency and readability, please format with spaces around = and < and space after ;:
for (int i = 0; i < numProps; i++) {…perty values Signed-off-by: Demai Ni <nidmgg@gmail.com>
|
All review comments have been addressed. |
bwatson-rti-org
pushed a commit
to bwatson-rti-org/janusgraph
that referenced
this pull request
Mar 9, 2019
Issue 87 - Hadoop InputFormat tests should check property values
micpod
pushed a commit
to micpod/janusgraph
that referenced
this pull request
Nov 5, 2019
Issue 87 - Hadoop InputFormat tests should check property values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Demai Ni nidmgg@gmail.com
Thank you for contributing to JanusGraph.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master)?For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.