Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HBase 0.94 support #63

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

jerryjch
Copy link
Member

@jerryjch jerryjch commented Jan 24, 2017

#36 Remove HBase 0.94 support

@janusgraph-bot
Copy link

Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

@janusgraph-bot janusgraph-bot added the cla: no This PR is not compliant with the CLA label Jan 24, 2017
@jerryjch
Copy link
Member Author

@mbrukman
Is the 'cla:no' because I used a different email in the commit?

@hsaputra
Copy link
Member

Yeah, it has to use the same name you used in the ICLA

@mbrukman
Copy link
Member

@jerryjch:

  • by "deprecate", I believe you actually mean "delete" — deprecate doesn't remove code, just marks it as @deprecated or similar
  • @hsaputra is correct: the email address used in this commit does not match the one on the CCLA, which are listed in this file
  • you also did not add the Signed-off-by: ... line as per the DCO requirement from The Linux Foundation

My recommendations:

  • rename this issue: s/Deprecate/Delete/ (or Remove), similarly for PR and commit descriptions

  • change the email used by default in your local repo clone:

    git config user.email ...     # as per CCLA
  • update the commit (both description + email)

    git commit -s --amend

    This will let you edit the commit description, and will auto-update the email address at the same time to use the one in your config. The -s flag will add the Signed-off-by line. To make this easier, see the instructions in CONTRIBUTING.md — search for alias.

  • update this PR in-place:

    git push -f

Once you do this, @janusgraph-bot will review the commit and update the tags accordingly.

@jerryjch jerryjch changed the title Deprecate HBase 0.94 support Remove HBase 0.94 support Jan 24, 2017
@jerryjch
Copy link
Member Author

@mbrukman Thanks for inputting. I updated the PR title, issue title, etc to 'Remove HBase 0.94 support'.
Use sign-off and amend the commit.

Signed-off-by: Jerry He <jinghe@us.ibm.com>
@jerryjch
Copy link
Member Author

jerryjch commented Jan 24, 2017

Had to use git commit -s --amend --reset-author
to get the email from the new git config.

@janusgraph-bot janusgraph-bot added cla: yes This PR is compliant with the CLA and removed cla: no This PR is not compliant with the CLA labels Jan 24, 2017
@jerryjch jerryjch self-assigned this Jan 24, 2017
@jerryjch
Copy link
Member Author

@mbrukman Looks like my merge permission is not up yet.
Also from the command like, it got rejected as well:

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information.
To git@github.com:JanusGraph/janusgraph
! [remote rejected] upstream-master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:JanusGraph/janusgraph'

Could you check my permission?

@mbrukman
Copy link
Member

@jerryjch try again?

@jerryjch jerryjch merged commit 22f584d into JanusGraph:master Jan 25, 2017
@jerryjch jerryjch deleted the deprecate-hbase-094 branch January 25, 2017 02:38
@jerryjch
Copy link
Member Author

@mbrukman The command line push still does not work. But merge PR worked. Thanks.

micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This PR is compliant with the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants