New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reactivate mic when inc. mycroft message has 'expect_response' #13

Merged

JarbasAl merged 1 commit into master from expect-response

May 8, 2021

Contributor

ChanceNCounter commented Apr 23, 2021

No description provided.


          reactivate mic when inc. mycroft message has 'expect_response'

60b5ee7

ChanceNCounter requested a review from JarbasAl

April 23, 2021 16:23

Member

JarbasAl commented May 8, 2021

looks good and i will merge it, but note this is not enough for full conversational mode

mycroft-core (master):

skills might hijack converse method, it simply is not multi-client aware
i am not positive that all messages are being routed properly when interacting with converse, need to do a review in upstream

regardless, those quirks are out of scope for now, this PR is still valid

JarbasAl merged commit d92b95a into master

JarbasAl deleted the expect-response branch

May 8, 2021 13:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment