Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase precision to CSS class to correct wrong behaviour #25

Closed
eRfO opened this issue Dec 23, 2016 · 7 comments
Closed

Increase precision to CSS class to correct wrong behaviour #25

eRfO opened this issue Dec 23, 2016 · 7 comments

Comments

@eRfO
Copy link

eRfO commented Dec 23, 2016

We have to add these CSS classes to fix a wrong behaviour with some display resolutions:

@media only screen and (min-width: 75em) {
  .rl-col-lg-2 {
    -ms-flex-preferred-size: 16.66666667%;
    flex-basis:16.66666667%;
    max-width: 16.66666667%;
  }
}

@media only screen and (min-width: 62em) {
  .rl-col-md-2 {
    -ms-flex-preferred-size: 16.66666667%;
    flex-basis: 16.66666667%;
    max-width: 16.66666667%;
  }
}

@media only screen and (min-width: 48em) {
  .rl-col-sm-2 {
    -ms-flex-preferred-size: 16.66666667%;
    flex-basis: 16.66666667%;
    max-width: 16.66666667%;
  }
}
@JarekToro
Copy link
Owner

Thank you for the code fixes, what is the "wrong behavior" your experiencing

@JarekToro
Copy link
Owner

@eRfO I would like to add this. I just need a description of what had how this fixes it.

@JarekToro
Copy link
Owner

Closing for now. @eRfO feel free to comment back id love to know more.

@eRfO
Copy link
Author

eRfO commented Jan 3, 2017

@JarekToro i post 2 images that show the wrong behavior. The first image is an example without the fix while the second show the right behavior.

without-fix
with-fix

@JarekToro
Copy link
Owner

Perfect thank you.

@JarekToro JarekToro reopened this Jan 3, 2017
@JarekToro
Copy link
Owner

Added and tested code. Thanks again. I will upload to Vaadin Directory soon and close this after.

@JarekToro
Copy link
Owner

Apologizes on the extremely long delay.

Fixed in latest release. Now on Vaadin Directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants