added withStyleName methods to layout, row and column (resolves JarekToro/responsive-layout#30) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You the man! After business hours I will review it and accept then put in directory. Really Appreciate the PR! |
|
Thanks again! Its in latest release. Now on Vaadin Directory |
|
That was fast. Thank you for accepting the PR. Your addon is exactly the part I was missing in Vaadin to not longing for Bootstrap. |
|
Thats awesome to hear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasn't sure how to fit a belonging test for this into your project. Just give me a hint howto if you want me to do it. Also added a withStyleName method to layout. Just throw it away if you don't want this (there are no other of these convenience methods there).