Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version and fix deprecation warnings #164

Conversation

rmichalak
Copy link
Contributor

This PR:

  • upgrades Node version to 16
  • updates 'core' package which also removes deprecation warnings for saveState function
  • updates tests accordingly
  • updates ncc
  • updates actions to remove deprecation messages

Fixes #149

Copy link
Collaborator

@jmealo jmealo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Collaborator

@jmealo jmealo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jmealo jmealo merged commit c8cbcd9 into JarvusInnovations:main May 23, 2023
2 checks passed
@jmealo
Copy link
Collaborator

jmealo commented May 23, 2023

@rmichalak Thanks Robert! Looks great. I went ahead and merged it :)

@rmichalak
Copy link
Contributor Author

@jmealo Thanks!
Can you please release a new version now?

@jmealo
Copy link
Collaborator

jmealo commented May 23, 2023

Sure thing. Will take a look tonight. @themightychris

@jmealo
Copy link
Collaborator

jmealo commented May 24, 2023

@rmichalak I tagged a v1.0.1 release with your changers and published it. Thanks again for your PR!

@jmealo
Copy link
Collaborator

jmealo commented May 24, 2023

@rmichalak try v1.0.3

@rmichalak
Copy link
Contributor Author

Thanks! It works for me. No more deprecation warnings in GitHub 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated save-state
2 participants