-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump node version and fix deprecation warnings #164
Bump node version and fix deprecation warnings #164
Conversation
GitHub is now using an environment file to store state by default, when GITHUB_STATE is defined: https://github.com/actions/toolkit/blob/main/packages/core/src/core.ts#L352-L359 which breaks the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
@rmichalak Thanks Robert! Looks great. I went ahead and merged it :) |
@jmealo Thanks! |
Sure thing. Will take a look tonight. @themightychris |
@rmichalak I tagged a |
@rmichalak try |
Thanks! It works for me. No more deprecation warnings in GitHub 🚀 |
This PR:
saveState
functionncc
Fixes #149