Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade from node 16 to 20 #184

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Multimo
Copy link

@Multimo Multimo commented Feb 9, 2024

#185

Upgrades node to use v20 and also upgrades some of the internal actions to v4 so that they also use v20.

Not quite sure how to test this so any direction here would be helpful :)

@cclauss
Copy link
Contributor

cclauss commented Feb 17, 2024

You can automate most of these changes by using GitHub's Dependabot.

@marcinlesek
Copy link

Thank you @Multimo 🎉

@ryon @themightychris can you folks please take a look on that? Now all Actions shows warning about this deprecation. 🙏🏻

@till
Copy link

till commented Mar 28, 2024

Can haz merge? 😄

@jmealo
Copy link
Collaborator

jmealo commented Mar 28, 2024

@till: I need to check with @themightychris that the hologit part works with Node 20, if so we should be good to merge this

@jmealo
Copy link
Collaborator

jmealo commented Mar 28, 2024

@till: @cclauss: I checked with @themightychris, the changes you made are correct, however, we need to push an update for hologit that supports Node 20 for them to work. I can't commit to when this would happen but he's aware of the issue. Once hologit supports Node 20, we should be able to merge this.

@themightychris themightychris merged commit 597e199 into JarvusInnovations:main Apr 6, 2024
@till
Copy link

till commented Apr 6, 2024

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants