Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add since and until (lichess) #16

Merged
merged 6 commits into from
Aug 20, 2023
Merged

add since and until (lichess) #16

merged 6 commits into from
Aug 20, 2023

Conversation

py-b
Copy link
Contributor

@py-b py-b commented Aug 15, 2023

A proposition for adding a filter by date for the get_raw_lichess function.

@JaseZiv
Copy link
Owner

JaseZiv commented Aug 17, 2023

Thanks for the PR @py-b!

Can you also complete the following:

  • Update the version in the DESCRIPTION file to 1.5.3
  • Update NEWS.md
  • Update test(s) in tests/testthat/test-chessR.R
  • Provide a summary of devtools::check()

@py-b
Copy link
Contributor Author

py-b commented Aug 17, 2023

Done. ✅

Here is the summary of devtools::check() :

-- R CMD check results -------------------------------------------------------------------------------- chessR 1.5.3 ----
Duration: 6m 11.2s

> checking for unstated dependencies in examples ... OK
   WARNING
  'qpdf' is needed for checks on size reduction of PDFs

> checking package dependencies ... NOTE
  Package suggested but not available for checking: 'chess'

0 errors v | 1 warning x | 1 note x

@JaseZiv JaseZiv self-requested a review August 20, 2023 23:01
Copy link
Owner

@JaseZiv JaseZiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks for making all those changes!

@JaseZiv JaseZiv merged commit 04879a3 into JaseZiv:master Aug 20, 2023
3 checks passed
@py-b py-b deleted the since-until branch August 21, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants