Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fotmob_get_match_players #298

Closed
daanih85 opened this issue Jul 3, 2023 · 4 comments · Fixed by #303
Closed

fotmob_get_match_players #298

daanih85 opened this issue Jul 3, 2023 · 4 comments · Fixed by #303
Assignees

Comments

@daanih85
Copy link

daanih85 commented Jul 3, 2023

Hi!

It seems like Fotmob have changed things around as scraping player stats now looks like this:

Skjermbilde 2023-07-03 kl  19 14 17

Wondering if this is fixable?


library(worldfootballR)
packageVersion("worldfootballR")
[1] ‘0.6.3.7fotmob_matches <- c(3609994, 3610132)
players <- fotmob_get_match_players(fotmob_matches)
@daanih85 daanih85 changed the title Issue running fotmob_get_match_players fotmob_get_match_players Jul 3, 2023
@tonyelhabr tonyelhabr self-assigned this Jul 7, 2023
@tonyelhabr
Copy link
Collaborator

Ah yes, that looks like a data change on their end. I'm not sure I'll get to it this weekend, but maybe next week.

@kidshiva
Copy link

kidshiva commented Jul 21, 2023

Hi both,

Just checked the merge fix for fotmob_get_match_players and it looks like there is an issue with the data

after a certain point in the nesting, the players data doesnt change for the player. i have attached a screenshot of what I am seeing, but it seems to be repeating the data for three or four players at a time rather than giving the individual players data

image

Using worldfootballR_0.6.3.0010

players <- fotmob_get_match_players(c(4074485))

@heartsstats
Copy link

Just found the same issue. Looks like there is an issue with players from the same team and having the same value in the position_row column having their stats values linked together in error.

@tonyelhabr
Copy link
Collaborator

being addressed with #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants