feat(collections): collections module for object management wrt mongodb #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
ypkang
commented
Apr 24, 2024
| T = TypeVar("T") | ||
|
|
||
|
|
||
| class BaseCollection(Generic[T]): |
There was a problem hiding this comment.
Should we create a parent interface class for this that is agnostic to the specific database vendor? And have a mongodb one inherit from it?
There was a problem hiding this comment.
Maybe we can do this later...something to consider.
|
|
||
| @staticmethod | ||
| def get_database() -> AsyncIOMotorDatabase: | ||
| """Return pymongo.database.Database for database connection based from current client connection.""" |
There was a problem hiding this comment.
how come this is not getting complained by linting for being too long?
| if session: | ||
| raise | ||
| logger.exception(f"Error bulk write:\n{ops}") | ||
| return {} |
There was a problem hiding this comment.
Can we add a few unit tests for the BaseCollection and UserCollection modules?
|
@amadolid I left some comments. Take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the collections module for the interfacing with mongodb.