Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(memory): memory module for interfacing with Redis #6

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(memory): memory module for interfacing with Redis #6

wants to merge 1 commit into from

Conversation

ypkang
Copy link
Contributor

@ypkang ypkang commented Apr 23, 2024 •
edited
Loading

Add Memory module for interfacing with Redis.

This was referenced Apr 23, 2024
Closed
Closed
ypkang
ypkang commented Apr 24, 2024
View reviewed changes
Copy link
Contributor Author

@ypkang ypkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me here. Similar to the collections PR, can we add a few unit tests for CommonMemory?

@ypkang ypkang marked this pull request as draft April 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ypkang ypkang

@amadolid amadolid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ypkang @amadolid