Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be great to have some zlib functions in the standard library #583

Closed
marsninja opened this issue Nov 6, 2022 · 6 comments · Fixed by #649
Closed

Would be great to have some zlib functions in the standard library #583

marsninja opened this issue Nov 6, 2022 · 6 comments · Fixed by #649
Assignees
Labels
good first issue Good for newcomers

Comments

@marsninja
Copy link
Contributor

marsninja commented Nov 6, 2022

Is your feature request related to a problem? Please describe.
It would be very useful if Jaseci had some gzip compatible standard library functions.

Describe the solution you'd like
It would be helpful if there were some actions like zlib.compress and zlib.decompress that can be used in the Jac programming language. To adhere to Jac's principles these functions should take in base64 strings as input and produce base64 as output. I'd think a good design would be to convert the base64 input into bytes, perform compression, then encode the compressed bytes into base64 again for the return.

If this feature request is accepted, would you be willing to work on a PR?
If time allows.

Additional context
I'd imagine this library would piggyback on pythons zlib functions.

@apatel66
Copy link
Contributor

apatel66 commented Nov 7, 2022

Hi, Matthew Wang (@Hextechagon) and I are juniors at the University of Michigan taking a software development class. Our latest assignment is to contribute to an open source project. We would like to contribute to Jaseci so would you be able to assign this issue to Matthew and I? Thanks!

@marsninja
Copy link
Contributor Author

Sure thing!

@marsninja marsninja assigned apatel66 and marsninja and unassigned apatel66 and marsninja Nov 7, 2022
@marsninja
Copy link
Contributor Author

@Hextechagon reply to this thread if you can. I'm trying to get github to let me assign you but I suspect you have to comment first.

@Hextechagon
Copy link

Hi @marsninja , can you assign this issue to me too? Thanks!

@ypkang
Copy link
Contributor

ypkang commented Nov 30, 2022

@Hextechagon assigned it to you. How is this coming along? Feel free to reach out to me or @marsninja if you need anything.

@Hextechagon
Copy link

Thanks, we're making progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants