Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zlib functionalities #649

Merged
merged 4 commits into from Dec 6, 2022
Merged

Add zlib functionalities #649

merged 4 commits into from Dec 6, 2022

Conversation

apatel66
Copy link
Contributor

@apatel66 apatel66 commented Dec 5, 2022

Added some zlib functions to the standard library (compress and decompress). Created associated tests as well.
Closes: #583.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@marsninja marsninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @apatel66 , On change needed, the jac/jac_parse files changed is likely due to not running black before commiting, by simply typing black . it should reformat properly then you can push.

@apatel66
Copy link
Contributor Author

apatel66 commented Dec 5, 2022

Nice work @apatel66 , On change needed, the jac/jac_parse files changed is likely due to not running black before commiting, by simply typing black . it should reformat properly then you can push.

Yep, that seemed to have worked. I only had the black formatter run whenever I saved a file in vscode, so I also added it to my terminal. Lmk if there is anything else to fix.

Copy link
Contributor

@marsninja marsninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @apatel66 !

@marsninja marsninja merged commit ea66cbe into Jaseci-Labs:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would be great to have some zlib functions in the standard library
3 participants