added test cases

apereo · Apr 22, 2015 · 5ed46ca · 5ed46ca
1 parent 775caee
commit 5ed46ca
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/cas-server-core/src/main/java/org/jasig/cas/CentralAuthenticationServiceImpl.java b/cas-server-core/src/main/java/org/jasig/cas/CentralAuthenticationServiceImpl.java
@@ -494,8 +494,9 @@ public TicketGrantingTicket createTicketGrantingTicket(final Credential... crede
             this.ticketRegistry.addTicket(ticketGrantingTicket);
             return ticketGrantingTicket;
         }
-        logger.warn("No credentials were specified in the request for creating a new ticket-granting ticket");
-        throw new TicketCreationException();
+        final String msg = "No credentials were specified in the request for creating a new ticket-granting ticket";
+        logger.warn(msg);
+        throw new TicketCreationException(new IllegalArgumentException(msg));
     }
 
     /**

diff --git a/cas-server-core/src/test/java/org/jasig/cas/CentralAuthenticationServiceImplTests.java b/cas-server-core/src/test/java/org/jasig/cas/CentralAuthenticationServiceImplTests.java
@@ -27,6 +27,7 @@
 import org.jasig.cas.services.UnauthorizedServiceException;
 import org.jasig.cas.services.UnauthorizedServiceForPrincipalException;
 import org.jasig.cas.services.UnauthorizedSsoServiceException;
+import org.jasig.cas.ticket.TicketCreationException;
 import org.jasig.cas.ticket.TicketException;
 import org.jasig.cas.ticket.ExpirationPolicy;
 import org.jasig.cas.ticket.ServiceTicket;
@@ -81,13 +82,26 @@ public void verifyDestroyTicketGrantingTicketWithValidTicket() throws Exception
         getCentralAuthenticationService().destroyTicketGrantingTicket(ticketId.getId());
     }
 
+    @Test(expected=TicketCreationException.class)
+    public void disallowNullCredentionalsWhenCreatingTicketGrantingTicket() throws Exception {
+        final TicketGrantingTicket ticketId = getCentralAuthenticationService()
+            .createTicketGrantingTicket(null);
+
+    }
+
+    @Test(expected=TicketCreationException.class)
+    public void disallowNullCredentionalsArrayWhenCreatingTicketGrantingTicket() throws Exception {
+        final TicketGrantingTicket ticketId = getCentralAuthenticationService()
+                .createTicketGrantingTicket(new Credential[] {null, null} );
+    }
+
     @Test(expected=ClassCastException.class)
     public void verifyDestroyTicketGrantingTicketWithInvalidTicket() throws Exception {
         final TicketGrantingTicket ticketId = getCentralAuthenticationService()
-            .createTicketGrantingTicket(
-                    TestUtils.getCredentialsWithSameUsernameAndPassword());
+                .createTicketGrantingTicket(
+                        TestUtils.getCredentialsWithSameUsernameAndPassword());
         final ServiceTicket serviceTicketId = getCentralAuthenticationService()
-            .grantServiceTicket(ticketId.getId(), TestUtils.getService());
+                .grantServiceTicket(ticketId.getId(), TestUtils.getService());
 
         getCentralAuthenticationService().destroyTicketGrantingTicket(
                 serviceTicketId.getId());