UP-3717 - session timeout #392
Conversation
… JS is not yet completed, but I think most of the basic backend work is good (except for universality).
…otstrap since bootstrap didn't work well in universality. Misc code cleanups.
|
Handy link to the JIRA issue. |
| @@ -30,15 +30,16 @@ | |||
| +--> | |||
| <folder ID="s2" hidden="true" immutable="true" name="Page Top folder" type="page-top" unremovable="true"> | |||
| <channel fname="dynamic-respondr-skin" unremovable="false" hidden="false" immutable="false" ID="n3"/> | |||
| <channel fname="fragment-admin-exit" unremovable="false" hidden="false" immutable="false" ID="n4"/> | |||
| <channel fname="fragment-admin-exit" unremovable="false" hidden="false" immutable="false" ID="n5"/> | |||
There was a problem hiding this comment.
What's going on here with changing the node ID of fragment-admin-exit from n4 to n5? And more generally with changing node identifiers throughout this file?
There was a problem hiding this comment.
As an unsolicited side note, there has been a trend in uPortal to keep the numbers sequential. I have found it annoying and contributing to a lot of noise. Maybe I should propose that we adopt a strategy of having the folder IDs 10 or 20 apart so we can add portlets without renumbering the file. I have better things to do with my time that manually reorganize IDs and I'm sure others too 😄 I'll throw that suggestion out to the dev list.
BTW Andrew aren't you supposed to be on vacation!!!
There was a problem hiding this comment.
Oops. I originally had the element in a different location and forgot to reset the numbers. Will fix.
There was a problem hiding this comment.
UP-4190 now tracks adopting a sparse out-of-the-box node identifier convention.
…values from the code.
| </preference> | ||
| <preference> | ||
| <name>dialogDisplaySeconds</name> | ||
| <value>60</value> |
There was a problem hiding this comment.
Worth a comment here explaining the meaning of this setting right where an adopter would be setting it? Something like
<!-- The session timeout warning will start displaying this many seconds before
the end of the user's session and will remain on the screen for this many seconds
(until the end of the session)
at which point the portlet will redirect to the logout URL specified in logoutURLFragment. -->
There was a problem hiding this comment.
Yep. Will add.
…ment to portlet.xml and changed "extend my session" button text to "Yes, keep me signed in" which is hopefully a bit more user-friendly.
|
Added comment based on apetro's suggestion. Changed wording for "extend my session" button to "Yes, keep me signed in" which should be a bit more user-friendly. |
UP-3717 - Add client-side warning re session timeout with opportunity to renew session.
No description provided.