Upgrade DataTables and include responsive plugin using CDN. Added loc… #624
Conversation
|
I've created a Jira for this, see https://issues.jasig.org/browse/UP-4653 |
|
The way datatables 1.9.4 had been added to the resource server caused multiple requests, if we are to add version 1.10 to the resource server I suggest we use a url scheme similar to that of the DataTabes CDN site e.g. /t/bs/dt-1.10.11,r-2.0.2/ We need to be clear what features are included/combined without requiring multiple requests. We loose some flexibility for change, but gain off-line working. I'm happy to make a PR on resource-server. |
|
@acolebourne -- James has some really cool ideas around enhancing the ResourceServer to use CDN URLs (instead of internal) when permitted and when they are available. I guess I'd like to preserve offline functionality as much as possible. |
|
@acolebourne see https://issues.jasig.org/browse/RESSERV-82. I've been trying to get to this for a while and haven't been able to carve out the time. Shouldn't be too difficult to do. I know you are passionate about parallelizing URL requests by using CDNs. If you have time to work on it before me, I think it would be great! |
|
@drewwills it would be good to get this upgrade into 4.3.0 so I'll resubmit using ResourceServer, I'll also make the corresponding PR on the ResourceServer repo. Hopefully before Thursday. |
…al copy of upgraded ColumnFilterWidgets plugin. Refactor all uses of DataTables to use the new API syntax
acolebourne
force-pushed
the
responsive-datatables-pull
branch
from
81f8f62
to
c64979f
Compare
update - Switched to using ResourceServerNote: The branch has been rebased |
…let, NotificationPortlet, and WebProxyPortlet
…emoving finance* and remedy* properties.
…tlets UP-4661: Upgrade 8 portlets and several overlay files
…oolExecutor with daemon threads (this detail was overlooked)
…; this commit focuses on org.jasig.portal.layout
…is pass completes that package, untill something changes)
UP-4668: Refactor GaP to make it clearer and more maintainable
…roperties, o.j.p.rendering, and a small piece of o.j.p.security
…elist.regexValues, titlePolicy, descriptionPolicy
…o4-3-0.txt since it is also in quickstart data set you'd typically pick up changes from it instead.
…text (portlet) dispatched request (this is a workaround)
…-rss-preferences UP-4673: Added missing NewsReader preferences to RSS definition
…ed vertically. fixed issue where border-radius was not showing in mobile menu
UP-4678: Prevent a ClassCastException on WebAsyncManager in cross-co…
… to which it applies, reducing vertical real estate
…indicate cannot change layout)
…user seeing portlet menu options they should not
navigation css changes.
UP-4654: Make the new 'hamburger' options menu float over the portle…
UP-4649: Round four of removing unused code with UCDetector
…e menu button (instead of position: fixed); Fix cosmetic issues with the flyout carrot on the active tab
UP-4622: Fix a display issue with the offcanvas menu on iOS
…al copy of upgraded ColumnFilterWidgets plugin. Refactor all uses of DataTables to use the new API syntax
…Portal into responsive-datatables-pull
|
It looks like this item just needs some busywork. I'll try to get to it. |
|
This is a change that we want, but the conflicts and aging of this PR take it beyond what we want to merge as-is. I hope we address it effectively in uP5. |
…al copy of upgraded ColumnFilterWidgets plugin. Refactor all uses of DataTables to use the new API syntax
NOTE: Marketplace has not been updated because it continues to function using the deprecated APIs. I will (re)submit a separate pull request for additional Marketplace UI improvements.