Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to alter soffit modelandview, only send encryptedToken #802

Closed
wants to merge 1 commit into from
Closed

Conversation

kdjohnson
Copy link
Contributor

Trying to modify the PortalRequest is causing a bunch of issues with trying to access the Bearer encryptedToken. So I believe that just passing the encryptedToken around allows for a few things. One, it allows for the render modelandview for the soffit to be altered thus allowing for user specific data to be added. Also, it has the added security benefit of only having the encryptedToken visible.

@bpowell
Copy link
Contributor

bpowell commented Jan 4, 2017

At OU we are trying to pass more information to the JSP, for example passing the IP address of the specific soffit to the page so it can grab js/css resources from it self. The only way to do this is per soffit. Also from a security stand point now the page only gets the encrypted token. It also cuts down on the payload being sent, allowing for faster response times.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewwills
Copy link
Contributor

Thanks for getting the dialog going again OU folks! I'm trying to get caught up on this item. It looks like there are a few things going on here.

Can we schedule a hangout? This one might go better as a live discussion.

@bpowell
Copy link
Contributor

bpowell commented Jan 5, 2017

@drewwills sure that works for me. I'm open from 8am-3pm tomorrow to talk about it.

@@ -123,8 +121,10 @@ public ModelAndView render(final HttpServletRequest req, final HttpServletRespon
// Set up cache headers appropriately
configureCacheHeaders(res, module);

return new ModelAndView(viewName.toString(), PORTAL_REQUEST_MODEL_NAME, portalRequest);
ModelAndView mav = new ModelAndView(viewName.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewName is already a String, so is the call to .toString() necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking with @bpowell. It seems like him and @drewwills have come to the conclusion of going a different route. Therefore, I'll be closing this request.

@kdjohnson kdjohnson closed this Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants