Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to alter soffit modelandview, only send encryptedToken #802

Closed
wants to merge 1 commit into from
Closed

Ability to alter soffit modelandview, only send encryptedToken #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...it-renderer/src/main/java/org/apereo/portal/soffit/renderer/SoffitRendererController.java
View file
Open in desktop
Expand Up @@ -82,8 +82,6 @@ public class SoffitRendererController {
*/
public static final String CACHE_MAXAGE_PROPERTY_FORMAT = PROPERTY_PREFIX + "%s.cache.max-age";

private static final String PORTAL_REQUEST_MODEL_NAME = "portalRequest";

private static final String DEFAULT_MODE = "view";
private static final String DEFAULT_WINDOW_STATE = "normal";

Expand Down Expand Up @@ -123,8 +121,10 @@ public ModelAndView render(final HttpServletRequest req, final HttpServletRespon
// Set up cache headers appropriately
configureCacheHeaders(res, module);

return new ModelAndView(viewName.toString(), PORTAL_REQUEST_MODEL_NAME, portalRequest);
ModelAndView mav = new ModelAndView(viewName.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewName is already a String, so is the call to .toString() necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking with @bpowell. It seems like him and @drewwills have come to the conclusion of going a different route. Therefore, I'll be closing this request.

mav.addObject("token", getBearer(req).getEncryptedToken());

return mav;
}

@ModelAttribute("bearer")
Expand Down