Quieter Logging #40
Merged
Quieter Logging #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason-Morcos
requested changes
Jan 11, 2023
index.js
Outdated
| @@ -480,7 +481,16 @@ class MagicOccupancy { | |||
| } | |||
|
|
|||
| _setOccupancyState (newVal) { | |||
| // Capture the previous state and determine if the state change should be logged | |||
| this.previousModeState = this.modeState; | |||
| this.occupancyLoggingCondition = (newVal == 'Occupied' && this.previousModeState == 'Unoccupied' || newVal == 'Unoccupied') | |||
There was a problem hiding this comment.
Last little thing - this shouldn't be a class-wide variable. I would probably use const here instead
const occupancyLoggingCondition = (newVal == 'Occupied' && this.previousModeState == 'Unoccupied' || newVal == 'Unoccupied')
if (this.occupancyLogging && occupancyLoggingCondition) {
There was a problem hiding this comment.
That makes sense. Thanks for the suggestion! The change has been made in dc54e03.
Jason-Morcos
approved these changes
Jan 16, 2023
|
Thanks for your help along the way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes and is related to issue #37:
Overall, this really cleans up the output to the Homebridge logs while allowing useful state change logging to be captured if desired.