Only reordering and grouping of methods in the interface, object and file. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Some of them are not easy to sort into categories. These are really about extending the length of a sequence: (I'm not sure what to call them)
|
|
Yeah, I struggled with concat and concatMap for far too long, so I finally just put them "anywhere" and was hoping you had a good category for them. I kind of think of concat as a SET operation (much like union), but I can't really find any evidence that fits in that category. |
Jason3S
requested changes
May 12, 2017
src/GenSequence.ts
Outdated
| reduceToSequence<U>(fnReduce: (previousValue: GenIterable<U>, currentValue: T, currentIndex: number) => GenIterable<U>, initialValue: GenIterable<U>): Sequence<U>; | ||
| scan(fnReduce: (previousValue: T, currentValue: T, currentIndex: number, array: T[]) => T, initialValue?: T): Sequence<T>; | ||
| scan<U>(fnReduce: (previousValue: U, currentValue: T, currentIndex: number, array: T[]) => U, initialValue: U): Sequence<U>; | ||
| combine<U, V>(fn: (t: T, u?: U) => V, j: Iterable<U>): Sequence<V>; | ||
| concat(j: Iterable<T>): Sequence<T>; | ||
| concatMap<U>(fn: (t: T) => Iterable<U>): Sequence<U>; |
There was a problem hiding this comment.
Let's put concat and concatMap into their own category: Extenders
|
I noticed that reduceToSequence wasn't in the readme, so I added it. Please take a close look at the wording there and see if you want any changes. |
|
Good catch with reduceToSequence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sure I didn't get this 100% correct, so fire away with your suggestions for improvements :)