This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
refactor(rxToStream): removes recursion, reduces overall size of impl… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementation No longer needs to pull in a lot of RxJS just for this implementation. Therefore, the overall bundle size of this implementation will be smaller. Also removes the recursion and the need for stackoverflow protection.
benlesh
force-pushed
the
update-rxToStream
branch
from
150e04d
to
83b857c
Compare
Jason3S
approved these changes
Jun 25, 2018
| while (_buffer.length > 0) { | ||
| const result = this.push(_buffer.shift()); | ||
| if (!result) break; | ||
| }; |
| if (this._waiting > 0) { | ||
| while (this._waiting > 0) { | ||
| this._waiting--; | ||
| const result = this.push(value); |
There was a problem hiding this comment.
What is the expected behavior if there are multiple waiting reads? It seems strange for that to occur, but it does mean the same data will be pushed multiple times.
| () => readable.push(null) | ||
| ); | ||
| if (!this._subscription) { | ||
| this._subscription = this._source.subscribe({ |
There was a problem hiding this comment.
What do you expect to happen for Observables that are hot or become hot before the first call to _read()? It seems like the data will get lost.
|
I just realized I hadn't published this. Thank you for you patience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ementation
No longer needs to pull in a lot of RxJS just for this implementation. Therefore, the overall bundle size of this implementation will be smaller.
Also removes the recursion and the need for stackoverflow protection.