Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Actions to Usage list #7

Merged
merged 1 commit into from Dec 2, 2018

Conversation

lannonbr
Copy link
Contributor

@lannonbr lannonbr commented Dec 1, 2018

I added two of my actions which use actions-toolkit to the usage list in the README.

@JasonEtco
Copy link
Owner

These are awesome! Thank you for adding them to the list 🎉 ❤️ I took a look at the code and I see a couple cases where actions-toolkit can be used more; I'll open some PRs and then merge this in 👍

@lannonbr
Copy link
Contributor Author

lannonbr commented Dec 2, 2018

Just merged in the two PRs you made. Just as a side note, I saw you commented that this made them easier to test, and with that, I'd love to learn how to test actions in general. Is there anywhere specifically you currently know of for documentation on such. I see for shell scripts you could use Bats, but for JS scripts that are placed in actions, what would you recommend looking at?

@JasonEtco
Copy link
Owner

Sweet!

Is there anywhere specifically you currently know of for documentation on such.

Unfortunately not - the difficulty of testing Actions is one of the main reasons I wanted to write this library. create-an-issue is a good example of a workaround - most of the functionality is outside of the main entrypoint (see IssueCreator), so its easier to write tests for the actual business logic. What it doesn't do is test the entire action, in its Docker container, with all of the context of previous workflows' effects. So - not a solved problem just yet I think!

@JasonEtco JasonEtco merged commit dff9498 into JasonEtco:master Dec 2, 2018
@lannonbr
Copy link
Contributor Author

lannonbr commented Dec 2, 2018

@JasonEtco Yeah it's a different workflow compared to the applications I usually write so it may take awhile to get my mind wrapped around how to test it. A scenario that may be good to look into is how serverless functions (AWS Lambda, Azure Functions, Google Cloud Functions, etc) are tested given they are kinda similar where they are activated through an event-based system.

@lannonbr lannonbr deleted the lannonbr-usecases-2018-12-01 branch December 2, 2018 23:37
@JasonEtco
Copy link
Owner

Agreed - I think FaaS and Actions are super similar conceptually. Lots of room for tooling there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants