Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fold the PR comment when tests are passing #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JasonEtco
Copy link
Owner

@JasonEtco JasonEtco commented Apr 7, 2018

Error logs are big and verbose which is extremely helpful, but only until the build is passing again. ci-reporter should hide the previous error logs when a PR is passing.

  • Update comment when build is passing
  • Ensure that when build fails again, the comment still works
  • Write tests

Closes #34

@codecov
Copy link

codecov bot commented Apr 7, 2018

Codecov Report

Merging #41 into master will decrease coverage by 9.32%.
The diff coverage is 38.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage     100%   90.67%   -9.33%     
==========================================
  Files           7        8       +1     
  Lines         102      118      +16     
  Branches       10       14       +4     
==========================================
+ Hits          102      107       +5     
- Misses          0        8       +8     
- Partials        0        3       +3
Impacted Files Coverage Δ
src/get-existing-comment.js 100% <100%> (ø)
src/index.js 76.08% <21.42%> (-23.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d79e59...3b0b8fd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant