Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce the number value into a string #47

Merged
merged 2 commits into from Mar 5, 2020

Conversation

lee-dohm
Copy link
Contributor

@lee-dohm lee-dohm commented Mar 5, 2020

Fixes #46

Made the requested change. I don't see any tests that explicitly cover this, but maybe I missed them in my rush 😬

@lee-dohm
Copy link
Contributor Author

lee-dohm commented Mar 5, 2020

Whoops, I'll fix that 😬

Copy link
Owner

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lee-dohm!!

@JasonEtco JasonEtco merged commit 7a1eb67 into JasonEtco:master Mar 5, 2020
@lee-dohm lee-dohm deleted the coerce-number branch March 5, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error logging the issue number
2 participants