Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release ID not in GitHub event #9

Closed
wants to merge 3 commits into from
Closed

Fix release ID not in GitHub event #9

wants to merge 3 commits into from

Conversation

Nadock
Copy link
Contributor

@Nadock Nadock commented Sep 19, 2019

For new GitHub actions, it seems the release ID is not in the event json supplied to the action. This pull request would change the upload script to retrieve the release ID from the API via the tag name.

Full disclousre: I haven't had a chance to properly test this yet - it may not completly work.

Update: Turns out I can't read documentation 馃槀 I've solved my issue and this PR is not needed. However, if you want to use it as a basis for uploading from other event types - go for it

@Nadock Nadock closed this Sep 19, 2019
@JasonEtco
Copy link
Owner

Thanks for opening this @Nadock - what part of the docs ended up clarifying this for you? If there's something that should be more obvious, would love to hear it!

@Nadock
Copy link
Contributor Author

Nadock commented Sep 19, 2019

It was mostly me not realising I was using a push event, not a release event to trigger my workflow. I didn't even initially realise you could use more than push or pull_request -- the GH docs on Actions are still very beta.

I do have some suggestions for the documentation for this project though, I'll open a new issue to details that 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants