Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style to initial Page issue #4 #36

Merged
merged 3 commits into from Mar 8, 2019

Conversation

@SahibArora
Copy link
Contributor

commented Mar 7, 2019

Hi have tried to style it.
Please give it look, I have styled first page/ main page.
If you would like I can work further with the same style.
Thanks!

@SahibArora

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

This is how it looks now:
image

Earlier:
image

No functionality has been touched, only CSS and some class names are added and changed

Thanks,

@JasonFritsche

This comment has been minimized.

Copy link
Owner

commented Mar 7, 2019

@SahibArora Can you add more contrast on the text/fonts? It's difficult to read the radio button text. Also, is the image free/royalty free, or free to use? Thanks

@SahibArora

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Sure, I will increase the contrast soon.
and yes, the photo is being taken from the unsplash.com. So, Its free to use.
Thanks,

@JasonFritsche

This comment has been minimized.

Copy link
Owner

commented Mar 8, 2019

@SahibArora I appreciate the effort, but I just ran this locally and the text is still difficult to read. I do like the picture though. I can't merge this PR at this time though based on the text being difficult to read.

@SahibArora

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

Its all good, I tried!
Thanks,

@JasonFritsche

This comment has been minimized.

Copy link
Owner

commented Mar 8, 2019

@SahibArora What about another image? something that is easier to use with text?

@SahibArora

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

Image change - looks a good Idea, Please have a look, what do you think of this one.
Thanks,

Now:
image

@JasonFritsche

This comment has been minimized.

Copy link
Owner

commented Mar 8, 2019

@SahibArora I like this image. I will merge this PR, but will leave the Style Issue open under issues, as it is an ongoing ticket where others can come in and manipulate the style. Nothing is set in stone in this project. I appreciate your contributions to the project.

@JasonFritsche JasonFritsche merged commit 35bfb99 into JasonFritsche:master Mar 8, 2019
@SahibArora

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

Sure, sounds good.
Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.