Development - Add Functional Tests for API + Removed Unused Endpoints (…

…#95) * Refactoring. * #93 - Functional tests for products controller. * #93 - Functional tests for products controller (GetById) * #93 - Functional tests for products controller (Create) * #93 - Functional tests for products controller (Update) * Remove misleading comments. * #93 - Functional tests for products controller (Delete) * #93 - Functional tests for customers controller * #93 - Functional tests for categories controller * Refactoring - removed unused employee manager code.
jasontaylordev · Mar 31, 2019 · 8618a44 · 8618a44
1 parent c029d6b
commit 8618a44
Show file tree

Hide file tree

Showing 41 changed files with 634 additions and 476 deletions.
diff --git a/Northwind.Application.Tests/Managers/ChangeEmployeeReportToCommandTest.cs b/Northwind.Application.Tests/Managers/ChangeEmployeeReportToCommandTest.cs
diff --git a/Northwind.Application.Tests/Reports/EmployeesWithManagersQueryTests.cs b/Northwind.Application.Tests/Reports/EmployeesWithManagersQueryTests.cs
diff --git a/Northwind.Application.Tests/Reports/EmployeesWithManagersQueryViewTests.cs b/Northwind.Application.Tests/Reports/EmployeesWithManagersQueryViewTests.cs
diff --git a/Northwind.Application/Customers/Commands/CreateCustomer/CreateCustomerCommand.cs b/Northwind.Application/Customers/Commands/CreateCustomer/CreateCustomerCommand.cs
@@ -34,16 +34,11 @@ public class CreateCustomerCommand : IRequest
         public class Handler : IRequestHandler<CreateCustomerCommand, Unit>
         {
             private readonly NorthwindDbContext _context;
-            private readonly INotificationService _notificationService;
             private readonly IMediator _mediator;
 
-            public Handler(
-                NorthwindDbContext context,
-                INotificationService notificationService,
-                IMediator mediator)
+            public Handler(NorthwindDbContext context, IMediator mediator)
             {
                 _context = context;
-                _notificationService = notificationService;
                 _mediator = mediator;
             }
 
@@ -67,7 +62,7 @@ public async Task<Unit> Handle(CreateCustomerCommand request, CancellationToken
 
                 await _context.SaveChangesAsync(cancellationToken);
 
-                await _mediator.Publish(new CustomerCreated { CustomerId = entity.CustomerId });
+                await _mediator.Publish(new CustomerCreated { CustomerId = entity.CustomerId }, cancellationToken);
 
                 return Unit.Value;
             }

diff --git a/Northwind.Application/Customers/Commands/DeleteCustomer/DeleteCustomerCommandHandler.cs b/Northwind.Application/Customers/Commands/DeleteCustomer/DeleteCustomerCommandHandler.cs
@@ -30,6 +30,7 @@ public async Task<Unit> Handle(DeleteCustomerCommand request, CancellationToken
             var hasOrders = _context.Orders.Any(o => o.CustomerId == entity.CustomerId);
             if (hasOrders)
             {
+                // TODO: Add functional test for this behaviour.
                 throw new DeleteFailureException(nameof(Customer), request.Id, "There are existing orders associated with this customer.");
             }
 

diff --git a/Northwind.Application/Customers/Commands/UpdateCustomer/UpdateCustomerCommandHandler.cs b/Northwind.Application/Customers/Commands/UpdateCustomer/UpdateCustomerCommandHandler.cs
@@ -20,7 +20,7 @@ public UpdateCustomerCommandHandler(NorthwindDbContext context)
         public async Task<Unit> Handle(UpdateCustomerCommand request, CancellationToken cancellationToken)
         {
             var entity = await _context.Customers
-                .SingleAsync(c => c.CustomerId == request.Id, cancellationToken);
+                .SingleOrDefaultAsync(c => c.CustomerId == request.Id, cancellationToken);
 
             if (entity == null)
             {

diff --git a/Northwind.Application/Employees/Commands/ChangeEmployeesManagerCommand.cs b/Northwind.Application/Employees/Commands/ChangeEmployeesManagerCommand.cs
diff --git a/Northwind.Application/Employees/Commands/ChangeEmployeesManagerCommandHandler.cs b/Northwind.Application/Employees/Commands/ChangeEmployeesManagerCommandHandler.cs
diff --git a/Northwind.Application/Employees/Models/EmployeeManagerModel.cs b/Northwind.Application/Employees/Models/EmployeeManagerModel.cs
diff --git a/Northwind.Application/Employees/Queries/EmployeesWithManagersQuery.cs b/Northwind.Application/Employees/Queries/EmployeesWithManagersQuery.cs
diff --git a/Northwind.Application/Employees/Queries/EmployeesWithManagersQueryHandler.cs b/Northwind.Application/Employees/Queries/EmployeesWithManagersQueryHandler.cs
diff --git a/Northwind.Application/Managers/Commands/ChangeEmployeeReportToCommand.cs b/Northwind.Application/Managers/Commands/ChangeEmployeeReportToCommand.cs
diff --git a/Northwind.Application/Managers/Commands/ChangeEmployeeReportToCommandHandler.cs b/Northwind.Application/Managers/Commands/ChangeEmployeeReportToCommandHandler.cs
diff --git a/Northwind.Application/Northwind.Application.csproj b/Northwind.Application/Northwind.Application.csproj
@@ -7,7 +7,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Dapper" Version="1.60.1" />
     <PackageReference Include="FluentValidation" Version="8.1.3" />
     <PackageReference Include="MediatR" Version="6.0.0" />
     <PackageReference Include="AutoMapper" Version="8.0.0" />

diff --git a/Northwind.Application/Products/Commands/DeleteProduct/DeleteProductCommandHandler.cs b/Northwind.Application/Products/Commands/DeleteProduct/DeleteProductCommandHandler.cs
@@ -29,6 +29,7 @@ public async Task<Unit> Handle(DeleteProductCommand request, CancellationToken c
             var hasOrders = _context.OrderDetails.Any(od => od.ProductId == entity.ProductId);
             if (hasOrders)
             {
+                // TODO: Add functional test for this behaviour.
                 throw new DeleteFailureException(nameof(Product), request.Id, "There are existing orders associated with this product.");
             }