-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Legacy style scrollbar context menu for easier navigation #495
base: master
Are you sure you want to change the base?
Conversation
Before you do change view, set this variable to false: Also, you can consider change selection point to 0 after user hit scroll to top button and change selection point to end of the document after user hit scroll to bottom. |
This doesn't work, also I am changing previous offsets before changing scroll position so it wouldn't be necessary.
Did this. |
This is why it is not going to work: When the context flyout is open, editor lost its focus, then you change the view right away and editor regain focus. Then editor itself change it's view to selection point (this is done by the internal logic which cannot be modified) and then it screws up the whole thing. Let me work on it, I think I might be able to find a workaround. |
Fix scrolling issue
I think I fixed the issue but still, there are two bugs that I don't even think are solvable:
This is as far as I can go, you can take from here. |
@soumyamahunt Any luck? Feel free to spin up another bug report to WinUI repo :) |
Filed here. |
This fixes horizontal scroll issue. However this issue not fixed:
|
Did you try removing the logic of doing two manual ChangeView events on the ScrollViewer that I did? |
Removing those makes the scrolling not work. Scrolling is again being reset after gaining focus. |
What about doing ITextRange ScrollIntoView after getting focus instead of doing it right away before ChangeView? |
Doesn't work this way either. |
Ok, let me give it a try. |
This PR implements notepad style scrollbar context menu but has some issues, @Jasonstein can you help with this??
PR Type
What kind of change does this PR introduce?
Other information
The ScrollViewer resets instantly after changing, I can't pinpoint the cause.