New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 82,loading indicator #87

Merged
merged 6 commits into from Dec 25, 2016

Conversation

Projects
None yet
3 participants
@wajahatch888
Contributor

wajahatch888 commented Dec 23, 2016

Loading indicator added on following

  1. Initail url load
    loading property is added in settings.plist.
  2. Href load url
    "href": { "url": "https://jasonbase.com/things/dhe.json", "loading": "true" }
  3. Network Request
    "reload": { "type": "$network.request", "options": { "url": "https://hardwax.com/this-week/", "dataType": "html", "loading", "true", },
@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Dec 24, 2016

Awesome! Could you run pod install and commit that as well, so that it can be directly integrated without a separate pod install from user side? Thanks!

@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Dec 24, 2016

BTW trying it out now and looks great!

Just one quick question: Is it possible to add a "fade out" animation? Just thought it would be nice if the loading faded away instead of suddenly disappearing.

But if it's too much hassle or hacky don't worry about it, it's great as is :)

@wajahatch888

This comment has been minimized.

Contributor

wajahatch888 commented Dec 24, 2016

@gliechtenstein , i will find some time to add "fade out" animation. One more thing, In future i will also add a feature to customise loader too.

@wajahatch888

This comment has been minimized.

Contributor

wajahatch888 commented Dec 24, 2016

@gliechtenstein , MBProgressHud added in git.

@wajahatch888

This comment has been minimized.

Contributor

wajahatch888 commented Dec 24, 2016

Fade In / Fade out animation added.

@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Dec 24, 2016

Hmm for some reason not all files from pod install seem to be included in the final build. It was missing some files which resulted in a build failure.

So I tried snapshotting before pod install and after. Below are the files that seem to be missing from the commit. Could you take a look? (Could it be a difference in CocoaPods binary version?) Maybe I'm missing something.. Thanks!

screen shot 2016-12-24 at 5 10 28 pm

@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Dec 25, 2016

@wajahatch888 I think loader can be more misleading than loading because people may interpret this as some module that loads the new view.

Let's just go with loading for now, we can always add another option to describe this later if we wanted to.

@gliechtenstein gliechtenstein merged commit aae2f5f into Jasonette:develop Dec 25, 2016

@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Dec 25, 2016

Thanks @wajahatch888 ! Great Christmas present :)

@gliechtenstein gliechtenstein referenced this pull request Dec 25, 2016

Closed

Loading indicator #82

@lukeramsden

This comment has been minimized.

Contributor

lukeramsden commented Dec 25, 2016

Nice work @wajahatch888 +1

@wajahatch888 wajahatch888 deleted the wajahatch888:Issue-82,Loading-Indicator branch Dec 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment