.NET 6 Support #300
Closed
.NET 6 Support #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@diegostamigni Thank you for doing that! But yeah, the test projects -- especially the ASP.Net Core integration really needs to be upgraded for safety. I can handle that later today. |
Yeah @jeremydmiller I had a feeling about that! Thanks for handling it then! 💪🤙 |
|
Got it in with a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
As other people have mentioned already, .NET 6.0 is officially out and it would be great if Lamar was setup to support it. The work isn't a big deal as it requires to replicate a few nugets configuration within the csprojs and making sure all tests pass.
I haven't touched the test targets so they are running under net5.0 still, not sure if we want to change these too.
Github actions have been updated as well to use .NET 6 instead of .NET 5.
See #298